Page MenuHomePhabricator

Propagate "unexpandable" PHIDs to feed notification recipient expansion
ClosedPublic

Authored by epriestley on Mar 21 2018, 6:15 PM.
Tags
None
Referenced Files
F14412610: D19244.diff
Tue, Dec 24, 1:14 PM
Unknown Object (File)
Fri, Dec 6, 3:42 AM
Unknown Object (File)
Sun, Dec 1, 7:38 AM
Unknown Object (File)
Nov 13 2024, 2:25 AM
Unknown Object (File)
Oct 20 2024, 7:53 AM
Unknown Object (File)
Oct 19 2024, 5:21 PM
Unknown Object (File)
Oct 2 2024, 2:44 AM
Unknown Object (File)
Sep 20 2024, 9:13 AM
Subscribers
None

Details

Summary

See PHI466. Ref T13108. Somewhat recently, new rules were added so that "Resigning" from a revision takes you off the default recipient list, even if you're still a member of a project or package that is still a reviewer or subscriber.

However, these rules don't currently apply to the similar expansion which occurs in notifications. If you resign from a revision you may still get some notifications (just not email) if a package or project you're a member of is a reviewer or subscriber.

(Possibly these should eventually share more code, but just get things working for now.)

Test Plan
  • Created a revision as A.
  • Added B as a reviewer.
  • Added a package B is an owner for as a reviewer.
  • As B, resigned. (Make sure B is also not an explicit subscriber.)
  • Commented on the revision as A.
    • Before: B is included in the expanded notification recipient list.
    • After: B is no longer included in the expanded notification recipient list.

Diff Detail

Repository
rP Phabricator
Branch
expand1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19892
Build 26959: Run Core Tests
Build 26958: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 21 2018, 6:56 PM
This revision was automatically updated to reflect the committed changes.