Page MenuHomePhabricator
Differential D19233

Correct the behavior of "Desktop Only" in Notifications preferences
ClosedPublic
Actions

Authored by epriestley on Mar 16 2018, 10:13 PM.
Tags
None
Referenced Files
F14896350: D19233.id.diff
Sun, Feb 9, 9:57 AM
F14890188: D19233.id46054.diff
Sun, Feb 9, 5:44 AM
F14890187: D19233.id46053.diff
Sun, Feb 9, 5:44 AM
F14890186: D19233.id.diff
Sun, Feb 9, 5:44 AM
F14890185: D19233.diff
Sun, Feb 9, 5:44 AM
F14885413: D19233.id.diff
Sun, Feb 9, 2:25 AM
Unknown Object (File)
Sat, Jan 25, 12:47 AM
Unknown Object (File)
Sat, Jan 25, 12:47 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13102: Plans: 2018 Week 11 Bonus Content
Commits
rPdbc72a05bc39: Correct the behavior of "Desktop Only" in Notifications preferences
Summary

See https://discourse.phabricator-community.org/t/desktop-only-notifications-mode-is-broken/1234. Ref T13102. The "Desktop Only" mode for notifications currently shows both desktop and web notifications.

In fact, JX.Notification currently has no ability to render notifications as desktop-only. Make this work.

Note that many of the variables and parameters here, including showAnyNotification, web_ready, and desktop_ready, are named in an incorrect or misleading way. However, the new behavior appears to be correct.

Test Plan
  • Emitted test notifications in "No Notifications", "Web Only", "Web and Desktop", and "Desktop" modes.
  • Saw appropriate notifications appear in the UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 16 2018, 10:13 PM
Harbormaster completed remote builds in B19870: Diff 46053.Mar 16 2018, 10:14 PM
epriestley requested review of this revision.Mar 16 2018, 10:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2018, 10:17 PM
Closed by commit rPdbc72a05bc39: Correct the behavior of "Desktop Only" in Notifications preferences (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
52 lines
webroot/
rsrc/
js/
application/
aphlict/
3 lines
core/
13 lines

Diff 46054

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/aphlict/behavior-aphlict-listen.js

Loading...
View Options

webroot/rsrc/js/core/Notification.js

Loading...
Phabricator · Built by Phacility