Page MenuHomePhabricator

Allow draft revisions to be commandeered
ClosedPublic

Authored by epriestley on Mar 14 2018, 9:01 PM.
Tags
None
Referenced Files
F19879449: D19228.diff
Tue, Mar 17, 9:42 PM
F19863043: D19228.diff
Mar 14 2026, 11:08 AM
F19859336: D19228.id46040.diff
Mar 14 2026, 3:34 AM
F19030295: D19228.id46039.diff
Nov 24 2025, 8:46 PM
F19030293: D19228.id46040.diff
Nov 24 2025, 8:45 PM
F19026507: D19228.diff
Nov 24 2025, 10:55 AM
F18899876: D19228.id.diff
Nov 7 2025, 8:18 PM
F18875927: D19228.diff
Nov 5 2025, 8:17 PM
Subscribers
None

Details

Summary

See PHI457. There's no real reason not to allow this, it just wasn't clear if it was useful. See D18626.

An install had a user arc diff and then sprint out the door to take a very long vacation before the builds finished. One failed, so the revision is stuck as a draft forever. This seems like a reasonable motivation for allowing "Commandeer".

Test Plan

Successfully commandeered a draft.

Diff Detail

Repository
rP Phabricator
Branch
comm1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19856
Build 26908: Run Core Tests
Build 26907: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 14 2018, 9:04 PM
This revision was automatically updated to reflect the committed changes.