Differential D19225

Don't make an expensive, unused call to test if a viewer can reassign a task
ClosedPublic
Actions

Authored by epriestley on Mar 14 2018, 7:14 PM.

Details

Reviewers: None
Maniphest Tasks: T13106: Task detail pages are issuing an egregious number of queries?
Commits: rPce6e020d5ddb: Don't make an expensive, unused call to test if a viewer can reassign a task

Summary

Depends on D19224. Ref T13106. Computing this is expensive and the value is not used. This came from D15432, but we never actually shipped that feature.

Test Plan

Saw local query cost drop from 139 to 110 with no change in functionality. Grepped for removed symbols.

Diff Detail

Repository

rP Phabricator

Branch

perf6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19847
Build 26896: Run Core Tests
Build 26895: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 14 2018, 7:14 PM

Harbormaster completed remote builds in B19847: Diff 46030.Mar 14 2018, 7:15 PM

epriestley requested review of this revision.Mar 14 2018, 7:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 14 2018, 7:46 PM

Closed by commit rPce6e020d5ddb: Don't make an expensive, unused call to test if a viewer can reassign a task (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestTaskDetailController.php

3 lines

transactions/

editengine/

PhabricatorEditEngine.php

53 lines

Diff 46030

View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php