Differential D19222

Bulk load builtin project default profile images
ClosedPublic
Actions

Authored by epriestley on Mar 14 2018, 6:25 PM.

Details

Reviewers: None
Maniphest Tasks: T13106: Task detail pages are issuing an egregious number of queries?
Commits: rP49e6358fce27: Bulk load builtin project default profile images

Summary

Depends on D19221. Ref T13106. When we fall back to default profile images for projects, bulk load them instead of doing individual queries.

Test Plan

Saw local task drop from 199 queries to 151 queries with the same actual outcome. Saw custom and default profile images on the project list page.

Diff Detail

Repository

rP Phabricator

Branch

perf3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19844
Build 26890: Run Core Tests
Build 26889: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 14 2018, 6:25 PM

epriestley mentioned this in T13106: Task detail pages are issuing an egregious number of queries?.Mar 14 2018, 6:26 PM

Harbormaster completed remote builds in B19844: Diff 46027.Mar 14 2018, 6:26 PM

epriestley requested review of this revision.Mar 14 2018, 6:26 PM

epriestley added a child revision: D19223: Skip loading attached objects for files when we know the file is visible.Mar 14 2018, 6:47 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 14 2018, 7:35 PM

Closed by commit rP49e6358fce27: Bulk load builtin project default profile images (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

query/

PhabricatorProjectQuery.php

66 lines

Diff 46027

View Options

src/applications/project/query/PhabricatorProjectQuery.php

Bulk load builtin project default profile imagesClosedPublicActions