Paths

Table of Contentst

Differential D19216

Issue setup guidance recommending MySQLi and MySQL Native Driver
ClosedPublic
Actions

Authored by epriestley on Mar 13 2018, 7:35 PM.

Tags

None

Referenced Files

	F14048660: D19216.diff
	Thu, Nov 14, 8:52 AM

	F14036744: D19216.diff
	Sun, Nov 10, 11:51 AM

	F14034388: D19216.id46015.diff
	Sat, Nov 9, 11:55 PM

	F14032639: D19216.diff
	Sat, Nov 9, 3:02 PM

	F14021360: D19216.diff
	Wed, Nov 6, 7:59 AM

	F14018092: D19216.id.diff
	Tue, Nov 5, 4:31 AM

	F14014944: D19216.id.diff
	Sun, Nov 3, 10:37 AM

	Unknown Object (File)
	Sep 20 2024, 2:04 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T12994: Add a setup warning if MYSQLI_ASYNC is not defined (support for MySQLi async)
Commits: rP0bf8e33bb6c1: Issue setup guidance recommending MySQLi and MySQL Native Driver

Summary

Fixes T12994. We need MYSQLI_ASYNC to implement client-side query timeouts, and we need MySQLi + MySQL Native Driver to get MYSQLI_ASYNC.

Recommend users install MySQLi and MySQL Native Driver if they don't have them. These are generally the defaults and best practice anyway, but Ubuntu makes it easy to use the older stuff.

All the cases we're currently aware of stem from apt-get install php5-mysql (which explicitly selects the non-native driver) so issue particular guidance about php5-mysqlnd.

Test Plan

Faked both issues locally, reviewed the text.
Will deploy to secure, which currently has the non-native driver.

Diff Detail

Repository

Branch

nd1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19833
Build 26873: Run Core Tests
Build 26872: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 13 2018, 7:35 PM

Harbormaster completed remote builds in B19833: Diff 46015.Mar 13 2018, 7:36 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 13 2018, 7:36 PM

epriestley requested review of this revision.

Closed by commit rP0bf8e33bb6c1: Issue setup guidance recommending MySQLi and MySQL Native Driver (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

4 lines

scripts/

install/

install_ubuntu.sh

2 lines

src/

applications/

config/

check/

PhabricatorPHPConfigSetupCheck.php

45 lines

docs/

user/

installation_guide.diviner

2 lines

webroot/

rsrc/

css/

application/

config/

setup-issue.css

2 lines

Diff 46015

resources/celerity/map.php

Loading...

scripts/install/install_ubuntu.sh

Loading...

src/applications/config/check/PhabricatorPHPConfigSetupCheck.php

Loading...

src/docs/user/installation_guide.diviner

Loading...

webroot/rsrc/css/application/config/setup-issue.css

Loading...