Page MenuHomePhabricator

Use a tokenizer, not a gigantic poorly-ordered "<select />", to choose repositories in Owners
ClosedPublic

Authored by epriestley on Mar 8 2018, 2:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 7:22 AM
Unknown Object (File)
Feb 20 2024, 4:03 AM
Unknown Object (File)
Feb 14 2024, 9:40 AM
Unknown Object (File)
Feb 10 2024, 6:03 PM
Unknown Object (File)
Feb 7 2024, 10:47 PM
Unknown Object (File)
Feb 3 2024, 6:23 PM
Unknown Object (File)
Jan 25 2024, 12:55 AM
Unknown Object (File)
Jan 20 2024, 3:19 AM
Subscribers
None

Details

Summary

Depends on D19190. Fixes T12590. Ref T13099. Replaces the barely-usable, gigantic, poorly ordered "<select />" control with a tokenizer. Attempts to fix various minor issues.

Test Plan
  • Edited paths: include/exclude paths, from different repositories, different actual paths.
  • Used "Add New Path" to add rows, got repository selector prepopulated with last value.
  • Used "remove".
  • Used validation typeahead, got reasonable behaviors?

The error behavior if you delete the repository for a path is a little sketchy still, but roughly okay.

Diff Detail

Repository
rP Phabricator
Branch
owners3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19779
Build 26794: Run Core Tests
Build 26793: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 4:57 AM
This revision was automatically updated to reflect the committed changes.