Page MenuHomePhabricator

Reduce the cost of generating default user profile images
ClosedPublic

Authored by epriestley on Mar 2 2018, 12:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 11:26 PM
Unknown Object (File)
Sun, Jan 19, 11:32 AM
Unknown Object (File)
Sun, Jan 19, 9:47 AM
Unknown Object (File)
Sun, Jan 12, 7:29 PM
Unknown Object (File)
Fri, Jan 3, 11:48 AM
Unknown Object (File)
Dec 30 2024, 8:50 AM
Unknown Object (File)
Dec 28 2024, 1:09 PM
Unknown Object (File)
Dec 24 2024, 2:56 AM
Subscribers
None
Tokens
"Burninate" token, awarded by jmeador.

Details

Summary

See PHI413. You can pre-generate these with bin/people profileimage --all, but they're needlessly expensive to generate.

Streamline the workflow and cache some of the cacheable parts to reduce the generation cost.

Test Plan
  • Ran bin/people profileimage --all and saw cost drop from 15.801s4.839s.
  • Set defaultProfileImagePHID to NULL in phabricator_user.user and purged caches with bin/cache purge --all.
  • Loaded user directory.
  • Saw default images regenerate relatively quickly.

Diff Detail

Repository
rP Phabricator
Branch
avatar1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19723
Build 26714: Run Core Tests
Build 26713: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2018, 12:52 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.