Paths

Table of Contentst

Differential D19153

When viewing a live build log, trap users in a small personal hell where nothing but slavish devotion to the log exists
ClosedPublic
Actions

Authored by epriestley on Feb 28 2018, 7:39 PM.

Tags

None

Referenced Files

	F14076277: D19153.diff
	Thu, Nov 21, 4:37 PM

	Unknown Object (File)
	Thu, Nov 14, 4:04 AM

	Unknown Object (File)
	Fri, Nov 8, 7:20 AM

	Unknown Object (File)
	Fri, Nov 8, 7:16 AM

	Unknown Object (File)
	Fri, Nov 8, 7:08 AM

	Unknown Object (File)
	Fri, Nov 8, 6:55 AM

	Unknown Object (File)
	Thu, Oct 24, 6:47 AM

	Unknown Object (File)
	Oct 19 2024, 10:44 PM

Subscribers

Restricted Owners Package

Tokens

"Burninate" token, awarded by jcox.

Details

Reviewers: None
Maniphest Tasks: T13088: Plans: Harbormaster UI usability and interconnectedness
Commits: rPf114b2dd7d4b: When viewing a live build log, trap users in a small personal hell where…

Summary

Depends on D19152. Ref T13088. This adds live log tailing. It is probably not the final version of this feature because it prevents escape once you begin tailing a log.

Test Plan

Used bin/harbormaster write-log --rate ... to write a log slowly. Viewed it in the web UI. Clicked "Follow Log". Followed the log until the write finished, a lifetime later.

Diff Detail

Repository

Branch

harbor6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19689
Build 26666: Run Core Tests
Build 26665: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 28 2018, 7:39 PM

Owners added a subscriber: Restricted Owners Package.Feb 28 2018, 7:39 PM

Harbormaster completed remote builds in B19689: Diff 45878.Feb 28 2018, 7:40 PM

epriestley requested review of this revision.Feb 28 2018, 7:40 PM

jcox awarded a token.Feb 28 2018, 7:52 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 28 2018, 8:38 PM

Closed by commit rPf114b2dd7d4b: When viewing a live build log, trap users in a small personal hell where… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

14 lines

src/

applications/

harbormaster/

controller/

HarbormasterBuildLogRenderController.php

74 lines

webroot/

rsrc/

css/

application/

harbormaster/

harbormaster.css

9 lines

js/

application/

harbormaster/

behavior-harbormaster-log.js

48 lines

Diff 45878

resources/celerity/map.php

Loading...

src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php

Loading...

webroot/rsrc/css/application/harbormaster/harbormaster.css

Loading...

webroot/rsrc/js/application/harbormaster/behavior-harbormaster-log.js

Loading...