Details
Details
Piped a sizable log into bin/harbormaster write-log with --rate 2048, saw a progress bar. Loaded the log in the web UI and saw it grow as the page reloaded.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- harbor5
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 19688 Build 26664: Run Core Tests Build 26663: arc lint + arc unit
Event Timeline
Comment Actions
99% of the time, yes, but it isn't very good for testing Harbormaster's behavior when you pipe a lot of of binary garbage with no newlines inside it (e.g., head -c99999999 /dev/zero | ...), or pipe in half a UTF8 character at a time so that the log continually ends in the middle of an emoji or something like that. I only expect this flag to be useful for testing/development and want it to be able to test those cases, and a byte-based rate can surface those better than a line-based rate.