Page MenuHomePhabricator
Differential D19115

Provide the document content as a context object when rendering Phriction documents
ClosedPublic
Actions

Authored by epriestley on Feb 16 2018, 8:41 PM.
Tags
None
Referenced Files
F13192941: D19115.diff
Sun, May 12, 10:53 AM
Unknown Object (File)
Sun, May 5, 7:20 PM
Unknown Object (File)
Thu, May 2, 7:30 AM
Unknown Object (File)
Wed, May 1, 12:54 AM
Unknown Object (File)
Fri, Apr 26, 1:14 AM
Unknown Object (File)
Tue, Apr 23, 3:23 AM
Unknown Object (File)
Fri, Apr 19, 7:25 PM
Unknown Object (File)
Apr 4 2024, 2:02 AM
View All 88 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13077: Plans: Phriction modern "v3" APIs, Drafts
Commits
rPcb2f7106069b: Provide the document content as a context object when rendering Phriction…
Summary

Ref T13077. The context object wasn't being passed into the engine properly here, affecting relative link rendering in Phriction.

Test Plan

Viewed rendered Phriction documents with relative links, got clean renders.

Diff Detail

Repository
rP Phabricator
Branch
phriction15
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19609
Build 26546: Run Core Tests
Build 26545: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 16 2018, 8:41 PM
Harbormaster completed remote builds in B19609: Diff 45805.Feb 16 2018, 8:42 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 8:42 PM
epriestley requested review of this revision.
Closed by commit rPcb2f7106069b: Provide the document content as a context object when rendering Phriction… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
storage/
1 line

Diff 45805

View Options

src/applications/phriction/storage/PhrictionContent.php

Loading...
Phabricator · Built by Phacility