Page MenuHomePhabricator

Let users escape more easily from the autosuggester after typing "[" or "("
ClosedPublic

Authored by epriestley on Feb 16 2018, 7:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 6:53 AM
Unknown Object (File)
Thu, Apr 25, 1:34 AM
Unknown Object (File)
Fri, Apr 19, 7:24 PM
Unknown Object (File)
Thu, Apr 11, 9:10 AM
Unknown Object (File)
Mar 30 2024, 6:55 PM
Unknown Object (File)
Mar 20 2024, 11:08 AM
Unknown Object (File)
Mar 20 2024, 11:06 AM
Unknown Object (File)
Mar 20 2024, 11:03 AM
Subscribers
None

Details

Summary

Ref T13077. The autosuggester is a little too eager right now, and will eat carriage returns after typing [ if you never activate the tokenizer.

To fix this, try just canceling sooner. If that doesn't work, we might need to cancel more eagerly by testing to see if the tokenizer is actually open.

Test Plan

Typed [x]<return>, got my return instead of getting trapped by the autosuggester.

Diff Detail

Repository
rP Phabricator
Branch
auto1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19598
Build 26530: Run Core Tests
Build 26529: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Draft.Feb 16 2018, 7:02 PM
This revision was automatically updated to reflect the committed changes.