Page MenuHomePhabricator
Differential D19049

Add a "Call webhooks" action to Herald
ClosedPublic
Actions

Authored by epriestley on Feb 9 2018, 8:23 PM.
Tags
None
Referenced Files
F14988003: D19049.diff
Sun, Feb 16, 3:09 PM
Unknown Object (File)
Tue, Feb 11, 4:05 AM
Unknown Object (File)
Sun, Feb 9, 5:20 AM
Unknown Object (File)
Sun, Feb 9, 5:20 AM
Unknown Object (File)
Sun, Feb 9, 5:20 AM
Unknown Object (File)
Sun, Feb 9, 12:49 AM
Unknown Object (File)
Thu, Jan 30, 2:30 PM
Unknown Object (File)
Tue, Jan 28, 3:18 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T11330: Allow Herald to "Queue Call to Webhook: ..."
Commits
rP98c701ffc55f: Add a "Call webhooks" action to Herald
Summary

Depends on D19048. Fixes T11330.

Test Plan

Wrote rules to call webhooks selectively, saw them fire appropriately with correct trigger attribution.

Diff Detail

Repository
rP Phabricator
Branch
hook5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19463
Build 26331: Run Core Tests
Build 26330: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 9 2018, 8:23 PM
Harbormaster completed remote builds in B19463: Diff 45666.Feb 9 2018, 8:23 PM
Harbormaster completed remote builds in B19463: Diff 45666.
epriestley requested review of this revision.Feb 9 2018, 8:24 PM
epriestley added a child revision: D19050: Document how webhooks work.Feb 9 2018, 9:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 9 2018, 9:57 PM
Closed by commit rP98c701ffc55f: Add a "Call webhooks" action to Herald (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
herald/
action/
62 lines
adapter/
14 lines
typeahead/
48 lines
transactions/
editor/
1 line

Diff 45666

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/action/HeraldCallWebhookAction.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/typeahead/HeraldWebhookDatasource.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility