Page MenuHomePhabricator
Differential D19048

Trigger all "Firehose" webhooks on all transactional edits
ClosedPublic
Actions

Authored by epriestley on Feb 9 2018, 8:09 PM.
Tags
None
Referenced Files
F15530070: D19048.diff
Wed, Apr 23, 1:15 AM
F15521490: D19048.diff
Sun, Apr 20, 2:45 PM
F15475976: D19048.diff
Mon, Apr 7, 1:58 AM
F15460612: D19048.id45665.diff
Tue, Apr 1, 12:25 AM
F15460304: D19048.id.diff
Mon, Mar 31, 9:46 PM
F15432456: D19048.id45672.diff
Mar 24 2025, 6:15 PM
F15430053: D19048.diff
Mar 24 2025, 5:30 AM
F15393649: D19048.id45672.diff
Mar 15 2025, 10:57 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T11330: Allow Herald to "Queue Call to Webhook: ..."
Commits
rP41d28abfcc46: Trigger all "Firehose" webhooks on all transactional edits
Summary

Depends on D19047. Ref T11330. Triggers every firehose hook on every edit; prepares for Herald triggers.

Test Plan

Configured a firehose hook, edited some objects, saw callbacks.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 9 2018, 8:09 PM
Harbormaster completed remote builds in B19462: Diff 45665.Feb 9 2018, 8:10 PM
epriestley requested review of this revision.Feb 9 2018, 8:10 PM
epriestley added a child revision: D19049: Add a "Call webhooks" action to Herald.Feb 9 2018, 8:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 9 2018, 9:56 PM
Closed by commit rP41d28abfcc46: Trigger all "Firehose" webhooks on all transactional edits (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
controller/
1 line
editor/
9 lines
management/
3 lines
phid/
3 lines
storage/
8 lines
worker/
10 lines
transactions/
editor/
57 lines

Diff 45672

View Options

src/applications/herald/controller/HeraldWebhookTestController.php

Loading...
View Options

src/applications/herald/editor/HeraldWebhookEditor.php

Loading...
View Options

src/applications/herald/management/HeraldWebhookCallManagementWorkflow.php

Loading...
View Options

src/applications/herald/phid/HeraldWebhookRequestPHIDType.php

Loading...
View Options

src/applications/herald/storage/HeraldWebhookRequest.php

Loading...
View Options

src/applications/herald/worker/HeraldWebhookWorker.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility