Page MenuHomePhabricator
Differential D19048

Trigger all "Firehose" webhooks on all transactional edits
ClosedPublic
Actions

Authored by epriestley on Feb 9 2018, 8:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 7:46 PM
Unknown Object (File)
Sat, Nov 16, 9:09 PM
Unknown Object (File)
Tue, Nov 5, 5:43 AM
Unknown Object (File)
Wed, Oct 30, 7:03 AM
Unknown Object (File)
Oct 24 2024, 4:51 AM
Unknown Object (File)
Oct 21 2024, 11:44 PM
Unknown Object (File)
Oct 20 2024, 2:47 AM
Unknown Object (File)
Sep 17 2024, 9:45 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T11330: Allow Herald to "Queue Call to Webhook: ..."
Commits
rP41d28abfcc46: Trigger all "Firehose" webhooks on all transactional edits
Summary

Depends on D19047. Ref T11330. Triggers every firehose hook on every edit; prepares for Herald triggers.

Test Plan

Configured a firehose hook, edited some objects, saw callbacks.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 9 2018, 8:09 PM
Harbormaster completed remote builds in B19462: Diff 45665.Feb 9 2018, 8:10 PM
epriestley requested review of this revision.Feb 9 2018, 8:10 PM
epriestley added a child revision: D19049: Add a "Call webhooks" action to Herald.Feb 9 2018, 8:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 9 2018, 9:56 PM
Closed by commit rP41d28abfcc46: Trigger all "Firehose" webhooks on all transactional edits (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
controller/
1 line
editor/
9 lines
management/
3 lines
phid/
3 lines
storage/
8 lines
worker/
10 lines
transactions/
editor/
57 lines

Diff 45672

View Options

src/applications/herald/controller/HeraldWebhookTestController.php

Loading...
View Options

src/applications/herald/editor/HeraldWebhookEditor.php

Loading...
View Options

src/applications/herald/management/HeraldWebhookCallManagementWorkflow.php

Loading...
View Options

src/applications/herald/phid/HeraldWebhookRequestPHIDType.php

Loading...
View Options

src/applications/herald/storage/HeraldWebhookRequest.php

Loading...
View Options

src/applications/herald/worker/HeraldWebhookWorker.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility