Page MenuHomePhabricator
Differential D19046

Refine core webhook implementation somewhat
ClosedPublic
Actions

Authored by epriestley on Feb 9 2018, 7:42 PM.
Tags
None
Referenced Files
F19907290: D19046.diff
Wed, Apr 1, 9:25 AM
F19639872: D19046.id45670.diff
Feb 5 2026, 5:27 PM
F19511050: D19046.id45670.diff
Jan 11 2026, 8:46 PM
F19189869: D19046.id45670.diff
Dec 16 2025, 8:44 AM
F18974217: D19046.id45670.diff
Nov 15 2025, 7:05 PM
F18871813: D19046.diff
Nov 5 2025, 12:41 AM
F18834581: D19046.id45670.diff
Oct 26 2025, 9:36 AM
F18650359: D19046.id.diff
Sep 21 2025, 12:26 AM
View All Files
Subscribers
ftdysa

Details

Reviewers
None
Maniphest Tasks
T11330: Allow Herald to "Queue Call to Webhook: ..."
Commits
rPdc2995c4ca3f: Refine core webhook implementation somewhat
Summary

Depends on D19045. Ref T11330.

  • View/regenerate HMAC keys.
  • Pretty JSON.
  • Readable status transactions.
  • test, silent, secure flags.
  • Dates on request view.
  • More icons.
  • Can test any object.
  • GC for requests.
Test Plan

Went through each feature poking at it in the web UI and with bin/webhook call ... / bin/garbage collect ....

Diff Detail

Repository
rP Phabricator
Branch
hook2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19460
Build 26325: Run Core Tests
Build 26324: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 9 2018, 7:42 PM
Harbormaster completed remote builds in B19460: Diff 45663.Feb 9 2018, 7:43 PM
epriestley requested review of this revision.Feb 9 2018, 7:43 PM
epriestley added a child revision: D19047: Allow "transaction.search" to be constrained by PHIDs.Feb 9 2018, 7:47 PM
ftdysa added a subscriber: ftdysa.Feb 9 2018, 7:54 PM
This comment was removed by ftdysa.
This revision was not accepted when it landed; it landed in state Needs Review.Feb 9 2018, 9:56 PM
Closed by commit rPdc2995c4ca3f: Refine core webhook implementation somewhat (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45663

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/application/PhabricatorHeraldApplication.php

Loading...
View Options

src/applications/herald/controller/HeraldWebhookKeyController.php

Loading...
View Options

src/applications/herald/controller/HeraldWebhookTestController.php

Loading...
View Options

src/applications/herald/controller/HeraldWebhookViewController.php

Loading...
View Options

src/applications/herald/garbagecollector/HeraldWebhookRequestGarbageCollector.php

Loading...
View Options

src/applications/herald/management/HeraldWebhookCallManagementWorkflow.php

Loading...
View Options

src/applications/herald/query/HeraldWebhookSearchEngine.php

Loading...
View Options

src/applications/herald/storage/HeraldWebhook.php

Loading...
View Options

src/applications/herald/storage/HeraldWebhookRequest.php

Loading...
View Options

src/applications/herald/view/HeraldWebhookRequestListView.php

Loading...
View Options

src/applications/herald/worker/HeraldWebhookWorker.php

Loading...
View Options

src/applications/herald/xaction/HeraldWebhookStatusTransaction.php

Loading...
Phabricator · Built by Phacility