Page MenuHomePhabricator

Fix a Phortune billing issue where subscription autopay could charge disabled cards
ClosedPublic

Authored by epriestley on Feb 7 2018, 3:23 PM.
Tags
None
Referenced Files
F13288371: D19020.diff
Tue, Jun 4, 10:20 AM
F13252935: D19020.diff
Sat, May 25, 2:13 AM
F13245916: D19020.diff
Thu, May 23, 6:35 AM
F13230751: D19020.diff
Mon, May 20, 11:18 PM
F13220494: D19020.id45589.diff
Sun, May 19, 1:33 AM
F13214371: D19020.id45618.diff
Fri, May 17, 10:08 AM
F13210440: D19020.diff
Fri, May 17, 4:51 AM
F13199487: D19020.diff
Mon, May 13, 3:16 PM
Subscribers
None

Details

Summary

See support email. There's nothing tricky here, we were just missing a check. The different parts of this got built at different times so I think this was simply overlooked.

Also add a redundant check just to future-proof this and be on the safe side.

Test Plan

Used bin/phortune invoice to charge a pact subscription. After deleting the card, the charge failed with an appropriate error.

Diff Detail

Repository
rP Phabricator
Branch
phortune1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19383
Build 26216: Run Core Tests
Build 26215: arc lint + arc unit

Event Timeline

I checked to see if PHI337 is another case of this, but as far as I can tell it isn't.

I'm checking to see if we've done this to anyone else, though.

We need to make some billing corrections here but I'll wait until this deploys.

epriestley mentioned this in Unknown Object (Maniphest Task).Feb 7 2018, 3:37 PM

I'll follow up in internally on T13067.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 2:31 PM
This revision was automatically updated to reflect the committed changes.