Page MenuHomePhabricator

Fix a Phortune billing issue where subscription autopay could charge disabled cards
ClosedPublic

Authored by epriestley on Feb 7 2018, 3:23 PM.
Tags
None
Referenced Files
F13177234: D19020.diff
Wed, May 8, 7:34 PM
Unknown Object (File)
Mon, Apr 29, 2:07 PM
Unknown Object (File)
Wed, Apr 24, 10:11 PM
Unknown Object (File)
Sun, Apr 21, 4:55 PM
Unknown Object (File)
Apr 6 2024, 3:45 AM
Unknown Object (File)
Apr 2 2024, 2:51 AM
Unknown Object (File)
Mar 23 2024, 5:03 AM
Unknown Object (File)
Mar 23 2024, 5:03 AM
Subscribers
None

Details

Summary

See support email. There's nothing tricky here, we were just missing a check. The different parts of this got built at different times so I think this was simply overlooked.

Also add a redundant check just to future-proof this and be on the safe side.

Test Plan

Used bin/phortune invoice to charge a pact subscription. After deleting the card, the charge failed with an appropriate error.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I checked to see if PHI337 is another case of this, but as far as I can tell it isn't.

I'm checking to see if we've done this to anyone else, though.

We need to make some billing corrections here but I'll wait until this deploys.

epriestley mentioned this in Unknown Object (Maniphest Task).Feb 7 2018, 3:37 PM

I'll follow up in internally on T13067.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 2:31 PM
This revision was automatically updated to reflect the committed changes.