Page MenuHomePhabricator

Add Differential and Herald mail stamps and some refinements
ClosedPublic

Authored by epriestley on Feb 5 2018, 8:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 7:18 PM
Unknown Object (File)
Thu, Nov 14, 3:42 PM
Unknown Object (File)
Wed, Nov 13, 10:51 PM
Unknown Object (File)
Sun, Nov 10, 8:05 AM
Unknown Object (File)
Tue, Nov 5, 9:33 PM
Unknown Object (File)
Oct 9 2024, 8:38 AM
Unknown Object (File)
Oct 7 2024, 9:26 PM
Unknown Object (File)
Sep 13 2024, 5:26 AM
Subscribers
None

Details

Summary

Ref T13053. Adds revision stamps (status, reviewers, etc). Adds Herald rule stamps, like the existing X-Herald-Rules header.

Removes the "self" stamps, since you can just write a rule against whatever(@epriestley) equivalently. If there's routing logic around this, it can live in the routing layer. This avoids tons of self-actor, self-mention, self-reviewer, self-blocking-reviewer, self-resigned-reviewer, etc., stamps.

Use natcasesort() instead of sort() so that numeric values (like monograms) sort 9, 80, 700 instead of 700, 80, 9.

Remove the commas from rendering since they don't really add anything.

Test Plan

Edited tasks and revisions, looked at mail stamps, saw stamps that looked pretty reasonable (with no more self stuff, no more commas, sorting numbers, and Herald stamps).

Diff Detail

Repository
rP Phabricator
Branch
stamps5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19343
Build 26151: Run Core Tests
Build 26150: arc lint + arc unit