Page MenuHomePhabricator

Add Differential and Herald mail stamps and some refinements
ClosedPublic

Authored by epriestley on Feb 5 2018, 8:06 PM.
Tags
None
Referenced Files
F17397076: D18997.id.diff
Sun, Jun 29, 5:05 AM
Unknown Object (File)
Mon, Jun 23, 6:50 PM
Unknown Object (File)
Tue, Jun 17, 7:32 AM
Unknown Object (File)
Mon, Jun 16, 1:12 PM
Unknown Object (File)
May 28 2025, 2:39 PM
Unknown Object (File)
May 25 2025, 1:20 PM
Unknown Object (File)
May 5 2025, 9:38 PM
Unknown Object (File)
Apr 26 2025, 12:13 AM
Subscribers
None

Details

Summary

Ref T13053. Adds revision stamps (status, reviewers, etc). Adds Herald rule stamps, like the existing X-Herald-Rules header.

Removes the "self" stamps, since you can just write a rule against whatever(@epriestley) equivalently. If there's routing logic around this, it can live in the routing layer. This avoids tons of self-actor, self-mention, self-reviewer, self-blocking-reviewer, self-resigned-reviewer, etc., stamps.

Use natcasesort() instead of sort() so that numeric values (like monograms) sort 9, 80, 700 instead of 700, 80, 9.

Remove the commas from rendering since they don't really add anything.

Test Plan

Edited tasks and revisions, looked at mail stamps, saw stamps that looked pretty reasonable (with no more self stuff, no more commas, sorting numbers, and Herald stamps).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable