Page MenuHomePhabricator

Allow revisions to revert commits and one another, and commits to revert revisions
ClosedPublic

Authored by epriestley on Jan 31 2018, 8:27 PM.
Tags
None
Referenced Files
F15456392: D18978.diff
Sun, Mar 30, 9:24 AM
F15455149: D18978.id45532.diff
Sat, Mar 29, 10:33 PM
F15454555: D18978.id45512.diff
Sat, Mar 29, 7:03 PM
F15448401: D18978.id.diff
Fri, Mar 28, 4:38 AM
F15443385: D18978.diff
Thu, Mar 27, 4:09 AM
F15440134: D18978.id.diff
Wed, Mar 26, 11:13 AM
F15434374: D18978.diff
Tue, Mar 25, 3:16 AM
F15401283: D18978.id45532.diff
Mon, Mar 17, 4:48 PM
Subscribers
None

Details

Summary

Ref T13057. This makes "reverts" syntax more visible and useful. In particular, you can now Reverts Dxx in a revision or commit, and Reverts <hash> from a revision.

When you do, the corresponding object will get a more-visible cross-reference marker in its timeline:

Screen Shot 2018-01-31 at 12.25.33 PM.png (46×360 px, 9 KB)

From here, we can look at surfacing revert information more heavily, since we can now query it on revision/commit pages via edges.

Test Plan

Used "reverts <hash>" and "reverts <revision>" in Differential and Diffusion, got sensible results in the timeline.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable