Page MenuHomePhabricator

Allow revisions to revert commits and one another, and commits to revert revisions

Authored by epriestley on Jan 31 2018, 8:27 PM.



Ref T13057. This makes "reverts" syntax more visible and useful. In particular, you can now Reverts Dxx in a revision or commit, and Reverts <hash> from a revision.

When you do, the corresponding object will get a more-visible cross-reference marker in its timeline:

From here, we can look at surfacing revert information more heavily, since we can now query it on revision/commit pages via edges.

Test Plan

Used "reverts <hash>" and "reverts <revision>" in Differential and Diffusion, got sensible results in the timeline.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 31 2018, 8:27 PM
epriestley requested review of this revision.Jan 31 2018, 8:28 PM
amckinley accepted this revision.Feb 2 2018, 1:09 AM
This revision is now accepted and ready to land.Feb 2 2018, 1:09 AM
This revision was automatically updated to reflect the committed changes.