Fix transcription of single-value bulk edit fields ("Assign to")
ClosedPublic
Actions

Authored by epriestley on Jan 31 2018, 6:40 PM.

Details

Reviewers

Commits

rPcff61e4d7882: (stable) Fix transcription of single-value bulk edit fields ("Assign to")
rPc9df8f77c8b5: Fix transcription of single-value bulk edit fields ("Assign to")

Summary

See PHI333. Some of the cleanup at the tail end of the bulk edit changes made "Assign To" stop working properly, since we don't strip the array(...) off the array(PHID) value we receive.

Test Plan

Used bulk editor to assign and unassign tasks (single value datasource).
Used bulk editor to change projects (multi-value datasource).

Diff Detail

Repository

rP Phabricator

Branch

bulk1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19295
Build 26074: Run Core Tests
Build 26073: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 31 2018, 6:40 PM

Harbormaster completed remote builds in B19295: Diff 45507.Jan 31 2018, 6:41 PM

epriestley requested review of this revision.Jan 31 2018, 6:41 PM

amckinley accepted this revision.Jan 31 2018, 6:42 PM

This revision is now accepted and ready to land.Jan 31 2018, 6:42 PM

Also fix a vaguely related issue with the "Change Points" JS control rendering.

Harbormaster completed remote builds in B19296: Diff 45508.Jan 31 2018, 6:43 PM

Closed by commit rPc9df8f77c8b5: Fix transcription of single-value bulk edit fields ("Assign to") (authored by epriestley). · Explain WhyJan 31 2018, 6:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

edittype/

PhabricatorPHIDListEditType.php

12 lines

Diff 45507

View Options

src/applications/transactions/edittype/PhabricatorPHIDListEditType.php

Fix transcription of single-value bulk edit fields ("Assign to")ClosedPublicActions