Page MenuHomePhabricator

Always use the same set of transactions to generate mail and mail tags
ClosedPublic

Authored by epriestley on Jan 26 2018, 2:55 PM.
Tags
None
Referenced Files
F13153437: D18941.diff
Sun, May 5, 3:13 AM
Unknown Object (File)
Fri, May 3, 8:06 AM
Unknown Object (File)
Thu, Apr 25, 2:03 AM
Unknown Object (File)
Fri, Apr 19, 7:12 PM
Unknown Object (File)
Thu, Apr 11, 9:37 AM
Unknown Object (File)
Sat, Apr 6, 8:30 AM
Unknown Object (File)
Apr 2 2024, 9:41 PM
Unknown Object (File)
Mar 5 2024, 10:21 AM
Subscribers
None

Details

Summary

See PHI307. Currently, when reviews undraft, we retroactively add in older activity to the mail ("alice created this revision...").

However, we don't add that activity to the mail tags, so the relevant tags (like "revision created") are dropped forever.

Instead, use the same set of transactions for both mail body and mail tag construction.

This should be obsoleted in the relatively near future by T10448, but it's a better/more correct behavior in general and we probably can't get rid of tags completely for a while.

Test Plan

Applied patch, created a revision with builds, saw it auto-undraft after builds finished. Used bin/mail list-outbound and bin/mail show-outbound to see the mail. Verified that it included retroactive text ("created this revision") AND retroactive tags.

Note that the tag for "A new revision is created" is DifferentialTransaction::MAILTAG_REVIEW_REQUEST with literal value differential-review-request.

Diff Detail

Repository
rP Phabricator
Branch
tags1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19197
Build 25934: Run Core Tests
Build 25933: arc lint + arc unit