Page MenuHomePhabricator

Bring new password validation into AuthPasswordEngine
ClosedPublic

Authored by epriestley on Jan 22 2018, 12:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 7:39 AM
Unknown Object (File)
Mon, Nov 18, 4:38 PM
Unknown Object (File)
Fri, Nov 15, 8:55 AM
Unknown Object (File)
Wed, Nov 13, 3:06 AM
Unknown Object (File)
Mon, Nov 11, 4:43 AM
Unknown Object (File)
Wed, Nov 6, 9:10 PM
Unknown Object (File)
Oct 25 2024, 12:42 AM
Unknown Object (File)
Oct 3 2024, 10:55 AM
Subscribers
None

Details

Summary

Ref T13043. We have ~4 copies of this logic (registration, lost password recovery, set password, set VCS password).

Currently it varies a bit from case to case, but since it's all going to be basically identical once account passwords swap to the new infrastructure, bring it into the Engine so it can live in one place.

This also fixes VCS passwords not being affected by account.minimum-password-length.

Test Plan

Hit all errors in "VCS Password" panel. Successfully changed password.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/auth/engine/PhabricatorAuthPasswordEngine.php
91

strlen($raw_confirm)?

This revision now requires changes to proceed.Jan 23 2018, 6:39 PM
  • Fix strlen().
  • Tested to actually hit this error.
  • Changed password.
This revision is now accepted and ready to land.Jan 23 2018, 6:43 PM
This revision was automatically updated to reflect the committed changes.