Page MenuHomePhabricator

Remove legacy transaction editor "getDisableEmail()" method
ClosedPublic

Authored by epriestley on Jan 19 2018, 3:48 PM.
Tags
None
Referenced Files
F18689409: D18881.id.diff
Fri, Sep 26, 6:03 PM
F18672527: D18881.diff
Thu, Sep 25, 7:40 AM
F18653101: D18881.diff
Sun, Sep 21, 11:06 AM
F18600948: D18881.diff
Sat, Sep 13, 11:05 AM
F18509236: D18881.id.diff
Fri, Sep 5, 3:18 AM
F18501950: D18881.diff
Thu, Sep 4, 10:04 PM
F18380809: D18881.id45273.diff
Aug 28 2025, 6:26 PM
F18379693: D18881.id45292.diff
Aug 28 2025, 4:27 PM
Subscribers
None

Details

Summary

Ref T13042. This is a very, very old policy-violating option from yesteryear which supported build systems publishing updates by adding comments to revisions, without sending email about it.

Harbormaster has served this role for a long time and this is policy-violating in the general case (it allows attackers to act in secret).

Test Plan

Grepped for affected symbols.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable