Page MenuHomePhabricator
Differential D18880

Organize bulk edit actions into nice groups
ClosedPublic
Actions

Authored by epriestley on Jan 19 2018, 3:34 PM.
Tags
None
Referenced Files
F14081173: D18880.diff
Fri, Nov 22, 6:41 PM
F14080938: D18880.diff
Fri, Nov 22, 5:31 PM
Unknown Object (File)
Mon, Nov 18, 3:19 AM
Unknown Object (File)
Sat, Nov 16, 7:54 AM
Unknown Object (File)
Thu, Nov 14, 3:40 AM
Unknown Object (File)
Sun, Nov 10, 1:41 PM
Unknown Object (File)
Wed, Nov 6, 3:05 AM
Unknown Object (File)
Thu, Oct 24, 4:52 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support
Commits
rP7a431813373a: Organize bulk edit actions into nice groups
Summary

Ref T13025. We're getting kind of a lot of actions, so put them in nice groups so they're easier to work with.

Test Plan

Screen Shot 2018-01-19 at 7.32.03 AM.png (534×269 px, 47 KB)

Diff Detail

Repository
rP Phabricator
Branch
bulk15
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19056
Build 25717: Run Core Tests
Build 25716: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 19 2018, 3:34 PM
Harbormaster completed remote builds in B19056: Diff 45272.Jan 19 2018, 3:35 PM
epriestley requested review of this revision.Jan 19 2018, 3:35 PM
amckinley accepted this revision.Jan 19 2018, 7:54 PM
This revision is now accepted and ready to land.Jan 19 2018, 7:54 PM
Closed by commit rP7a431813373a: Organize bulk edit actions into nice groups (authored by epriestley). · Explain WhyJan 19 2018, 9:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
21 lines
src/
2 lines
applications/
maniphest/
view/
2 lines
transactions/
bulk/
27 lines
26 lines
editengine/
75 lines
editfield/
10 lines
edittype/
14 lines
engineextension/
9 lines
4 lines
infrastructure/
customfield/
engineextension/
13 lines
webroot/
rsrc/
js/
core/
9 lines

Diff 45272

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/view/ManiphestTaskResultListView.php

Loading...
View Options

src/applications/transactions/bulk/PhabricatorBulkEditGroup.php

Loading...
View Options

src/applications/transactions/bulk/PhabricatorBulkEngine.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorEditField.php

Loading...
View Options

src/applications/transactions/edittype/PhabricatorEditType.php

Loading...
View Options

src/applications/transactions/engineextension/PhabricatorCommentEditEngineExtension.php

Loading...
View Options

src/applications/transactions/engineextension/PhabricatorEditEngineExtension.php

Loading...
View Options

src/infrastructure/customfield/engineextension/PhabricatorCustomFieldEditEngineExtension.php

Loading...
View Options

webroot/rsrc/js/core/behavior-bulk-editor.js

Loading...
Phabricator · Built by Phacility