Page MenuHomePhabricator

Reuse more transaction construction code in bulk editor
ClosedPublic

Authored by epriestley on Jan 19 2018, 1:53 PM.
Tags
None
Referenced Files
F19853150: D18875.id45286.diff
Fri, Mar 13, 5:53 AM
F19836525: D18875.id.diff
Wed, Mar 11, 10:53 AM
F19555005: D18875.id45286.diff
Jan 30 2026, 6:20 AM
F19551339: D18875.id45286.diff
Jan 28 2026, 1:13 PM
F19516326: D18875.id.diff
Jan 14 2026, 10:49 PM
F19514290: D18875.diff
Jan 14 2026, 12:23 AM
F19087806: D18875.id45286.diff
Dec 3 2025, 2:09 AM
F19087805: D18875.id45267.diff
Dec 3 2025, 2:09 AM
Subscribers
None

Details

Summary

Ref T13025. Currently, the bulk editor takes an HTTP request and emits a list of "raw" transactions (simple dictionaries). This goes into the job queue, and the background job builds a real transaction.

However, the logic to turn an HTTP request into a raw transaction is ending up with some duplication, since we generally already have logic to turn an HTTP request into a full object.

Instead: build real objects first, then serialize them to dictionaries. Send those to the job queue, rebuild them into objects again, and we end up in the same spot with a little less code duplication.

Finally, delete the mostly-copied code.

Test Plan

Used bulk editor to add comments, projects, and rename tasks.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable