Page MenuHomePhabricator

Reuse more transaction construction code in bulk editor
ClosedPublic

Authored by epriestley on Jan 19 2018, 1:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 24, 7:48 AM
Unknown Object (File)
Tue, Jul 23, 1:10 PM
Unknown Object (File)
Tue, Jul 23, 11:23 AM
Unknown Object (File)
Fri, Jul 19, 10:03 AM
Unknown Object (File)
Mon, Jul 15, 3:31 PM
Unknown Object (File)
Thu, Jul 11, 9:00 PM
Unknown Object (File)
Thu, Jul 11, 3:36 AM
Unknown Object (File)
Wed, Jul 10, 9:30 AM
Subscribers
None

Details

Summary

Ref T13025. Currently, the bulk editor takes an HTTP request and emits a list of "raw" transactions (simple dictionaries). This goes into the job queue, and the background job builds a real transaction.

However, the logic to turn an HTTP request into a raw transaction is ending up with some duplication, since we generally already have logic to turn an HTTP request into a full object.

Instead: build real objects first, then serialize them to dictionaries. Send those to the job queue, rebuild them into objects again, and we end up in the same spot with a little less code duplication.

Finally, delete the mostly-copied code.

Test Plan

Used bulk editor to add comments, projects, and rename tasks.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable