Page MenuHomePhabricator

Reuse more transaction construction code in bulk editor
ClosedPublic

Authored by epriestley on Jan 19 2018, 1:53 PM.
Tags
None
Referenced Files
F13086885: D18875.diff
Thu, Apr 25, 12:45 AM
Unknown Object (File)
Fri, Apr 19, 7:04 PM
Unknown Object (File)
Thu, Apr 18, 7:16 AM
Unknown Object (File)
Thu, Apr 11, 8:35 AM
Unknown Object (File)
Sat, Apr 6, 12:19 AM
Unknown Object (File)
Tue, Apr 2, 3:16 AM
Unknown Object (File)
Sat, Mar 30, 1:45 PM
Unknown Object (File)
Mar 10 2024, 6:41 AM
Subscribers
None

Details

Summary

Ref T13025. Currently, the bulk editor takes an HTTP request and emits a list of "raw" transactions (simple dictionaries). This goes into the job queue, and the background job builds a real transaction.

However, the logic to turn an HTTP request into a raw transaction is ending up with some duplication, since we generally already have logic to turn an HTTP request into a full object.

Instead: build real objects first, then serialize them to dictionaries. Send those to the job queue, rebuild them into objects again, and we end up in the same spot with a little less code duplication.

Finally, delete the mostly-copied code.

Test Plan

Used bulk editor to add comments, projects, and rename tasks.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable