Page MenuHomePhabricator

Reuse more transaction construction code in bulk editor
ClosedPublic

Authored by epriestley on Jan 19 2018, 1:53 PM.
Tags
None
Referenced Files
F19087806: D18875.id45286.diff
Wed, Dec 3, 2:09 AM
F19087805: D18875.id45267.diff
Wed, Dec 3, 2:09 AM
F19087627: D18875.diff
Wed, Dec 3, 1:37 AM
F19034738: D18875.diff
Tue, Nov 25, 2:48 PM
F18906839: D18875.diff
Nov 8 2025, 8:36 PM
F18876568: D18875.diff
Nov 6 2025, 1:50 AM
F18876567: D18875.diff
Nov 6 2025, 1:50 AM
F18814634: D18875.diff
Oct 20 2025, 11:38 PM
Subscribers
None

Details

Summary

Ref T13025. Currently, the bulk editor takes an HTTP request and emits a list of "raw" transactions (simple dictionaries). This goes into the job queue, and the background job builds a real transaction.

However, the logic to turn an HTTP request into a raw transaction is ending up with some duplication, since we generally already have logic to turn an HTTP request into a full object.

Instead: build real objects first, then serialize them to dictionaries. Send those to the job queue, rebuild them into objects again, and we end up in the same spot with a little less code duplication.

Finally, delete the mostly-copied code.

Test Plan

Used bulk editor to add comments, projects, and rename tasks.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable