Page MenuHomePhabricator

Reuse more transaction construction code in bulk editor
ClosedPublic

Authored by epriestley on Jan 19 2018, 1:53 PM.
Tags
None
Referenced Files
F15578053: D18875.id45286.diff
Tue, May 6, 5:27 PM
F15572880: D18875.diff
Mon, May 5, 6:12 PM
F15524813: D18875.id45267.diff
Mon, Apr 21, 10:31 AM
F15519381: D18875.id.diff
Sat, Apr 19, 10:19 PM
F15516550: D18875.diff
Fri, Apr 18, 7:38 PM
F15480604: D18875.id45267.diff
Apr 8 2025, 3:10 PM
F15474972: D18875.id45286.diff
Apr 6 2025, 2:34 PM
F15424943: D18875.diff
Mar 23 2025, 1:17 AM
Subscribers
None

Details

Summary

Ref T13025. Currently, the bulk editor takes an HTTP request and emits a list of "raw" transactions (simple dictionaries). This goes into the job queue, and the background job builds a real transaction.

However, the logic to turn an HTTP request into a raw transaction is ending up with some duplication, since we generally already have logic to turn an HTTP request into a full object.

Instead: build real objects first, then serialize them to dictionaries. Send those to the job queue, rebuild them into objects again, and we end up in the same spot with a little less code duplication.

Finally, delete the mostly-copied code.

Test Plan

Used bulk editor to add comments, projects, and rename tasks.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable