Page MenuHomePhabricator

Reuse more transaction construction code in bulk editor
ClosedPublic

Authored by epriestley on Jan 19 2018, 1:53 PM.
Tags
None
Referenced Files
F13303368: D18875.diff
Sat, Jun 8, 6:39 AM
F13287421: D18875.diff
Tue, Jun 4, 8:45 AM
F13286600: D18875.diff
Tue, Jun 4, 7:27 AM
F13274773: D18875.diff
Fri, May 31, 4:04 AM
F13267051: D18875.id45267.diff
Wed, May 29, 12:27 AM
F13261861: D18875.diff
Mon, May 27, 1:31 AM
F13206308: D18875.diff
Wed, May 15, 6:52 AM
F13186608: D18875.diff
May 11 2024, 3:44 AM
Subscribers
None

Details

Summary

Ref T13025. Currently, the bulk editor takes an HTTP request and emits a list of "raw" transactions (simple dictionaries). This goes into the job queue, and the background job builds a real transaction.

However, the logic to turn an HTTP request into a raw transaction is ending up with some duplication, since we generally already have logic to turn an HTTP request into a full object.

Instead: build real objects first, then serialize them to dictionaries. Send those to the job queue, rebuild them into objects again, and we end up in the same spot with a little less code duplication.

Finally, delete the mostly-copied code.

Test Plan

Used bulk editor to add comments, projects, and rename tasks.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable