Page MenuHomePhabricator

Support "Assign To" in Maniphest bulk editor
ClosedPublic

Authored by epriestley on Jan 19 2018, 1:18 PM.
Tags
None
Referenced Files
F13420204: D18874.id45266.diff
Mon, Jul 8, 6:43 AM
F13395182: D18874.id45266.diff
Wed, Jul 3, 1:38 PM
F13394278: D18874.diff
Wed, Jul 3, 6:39 AM
F13391387: D18874.id.diff
Tue, Jul 2, 9:33 AM
F13391206: D18874.id.diff
Tue, Jul 2, 8:40 AM
F13390994: D18874.diff
Tue, Jul 2, 7:35 AM
F13387226: D18874.diff
Mon, Jul 1, 6:37 AM
F13352586: D18874.diff
Sun, Jun 23, 2:12 PM
Subscribers
None

Details

Summary

Ref T13025. See PHI173. This supports the "Assign to" field in the new editor.

This is very slightly funky: to unassign tasks, you need to leave the field blank. I have half a diff to fix this, but the way the none() token works in the default datasource is odd so it needs a separate datasource. I'm punting on this for now since it works, at least, and isn't completely unreasonable.

This also simplifies some EditEngine stuff a little. Notably:

  • I reorganized EditType construction slightly so subclasses can copy/paste a little bit less.
  • EditType had field and editField properties which had the same values. I canonicalized on editField and made this value set a little more automatically.
Test Plan

Used bulk editor to reassign some tasks. By leaving the field blank, unassigned tasks.

Diff Detail

Repository
rP Phabricator
Branch
bulk9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19050
Build 25705: Run Core Tests
Build 25704: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 19 2018, 7:37 PM
This revision was automatically updated to reflect the committed changes.