Page MenuHomePhabricator

Support "Assign To" in Maniphest bulk editor

Authored by epriestley on Jan 19 2018, 1:18 PM.
Referenced Files
F13311617: D18874.diff
Tue, Jun 11, 5:16 AM
F13310793: D18874.diff
Mon, Jun 10, 6:53 PM
F13279209: D18874.diff
Sat, Jun 1, 12:35 PM
F13265103: D18874.diff
Tue, May 28, 1:22 AM
F13248754: D18874.diff
Fri, May 24, 4:03 AM
F13227775: D18874.diff
Mon, May 20, 5:07 AM
F13215556: D18874.id45285.diff
Fri, May 17, 6:10 PM
F13214276: D18874.diff
Fri, May 17, 9:40 AM



Ref T13025. See PHI173. This supports the "Assign to" field in the new editor.

This is very slightly funky: to unassign tasks, you need to leave the field blank. I have half a diff to fix this, but the way the none() token works in the default datasource is odd so it needs a separate datasource. I'm punting on this for now since it works, at least, and isn't completely unreasonable.

This also simplifies some EditEngine stuff a little. Notably:

  • I reorganized EditType construction slightly so subclasses can copy/paste a little bit less.
  • EditType had field and editField properties which had the same values. I canonicalized on editField and made this value set a little more automatically.
Test Plan

Used bulk editor to reassign some tasks. By leaving the field blank, unassigned tasks.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 19 2018, 7:37 PM
This revision was automatically updated to reflect the committed changes.