Add a couple of clarifying comments to the Mercurial protocol parser
ClosedPublic
Actions

Authored by epriestley on Jan 4 2018, 10:13 PM.

Tags

None

Referenced Files

	F15458797: D18859.id45240.diff
	Mon, Mar 31, 7:25 AM

	F15458242: D18859.id45240.diff
	Sun, Mar 30, 10:07 PM

	F15457831: D18859.id45239.diff
	Sun, Mar 30, 7:16 PM

	F15453474: D18859.id.diff
	Sat, Mar 29, 12:06 PM

	F15448850: D18859.diff
	Fri, Mar 28, 7:11 AM

	F15434449: D18859.diff
	Tue, Mar 25, 3:45 AM

	F15293832: D18859.diff
	Mar 5 2025, 4:56 AM

	Unknown Object (File)
	Feb 25 2025, 7:36 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13036: Fix issues with recent Mercurial wire protocol versions

Commits

rP554359203467: Add a couple of clarifying comments to the Mercurial protocol parser

Summary

See D18857. Ref T13036. See PHI275. Explain what's going on here a little better since it isn't entirely obvious and debugging these stream parsers is a gigantic pain.

Test Plan

Read text.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 4 2018, 10:13 PM

Harbormaster completed remote builds in B19021: Diff 45239.Jan 4 2018, 10:14 PM

epriestley requested review of this revision.Jan 4 2018, 10:14 PM

👍

This revision is now accepted and ready to land.Jan 4 2018, 10:15 PM

Closed by commit rP554359203467: Add a couple of clarifying comments to the Mercurial protocol parser (authored by epriestley). · Explain WhyJan 4 2018, 10:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

ssh/

DiffusionMercurialWireClientSSHProtocolChannel.php

19 lines

Diff 45240

View Options

src/applications/diffusion/ssh/DiffusionMercurialWireClientSSHProtocolChannel.php

Add a couple of clarifying comments to the Mercurial protocol parserClosedPublicActions