Add a couple of clarifying comments to the Mercurial protocol parser
ClosedPublic
Actions

Authored by epriestley on Jan 4 2018, 10:13 PM.

Tags

None

Referenced Files

	F14036193: D18859.diff
	Sun, Nov 10, 8:57 AM

	F14019329: D18859.diff
	Tue, Nov 5, 9:56 PM

	F14011350: D18859.id45240.diff
	Thu, Oct 31, 11:09 PM

	F13989791: D18859.id45239.diff
	Mon, Oct 21, 11:07 PM

	F13986475: D18859.diff
	Mon, Oct 21, 3:14 AM

	F13956651: D18859.id.diff
	Oct 14 2024, 6:34 AM

	Unknown Object (File)
	Sep 26 2024, 5:22 PM

	Unknown Object (File)
	Aug 25 2024, 11:54 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13036: Fix issues with recent Mercurial wire protocol versions

Commits

rP554359203467: Add a couple of clarifying comments to the Mercurial protocol parser

Summary

See D18857. Ref T13036. See PHI275. Explain what's going on here a little better since it isn't entirely obvious and debugging these stream parsers is a gigantic pain.

Test Plan

Read text.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 4 2018, 10:13 PM

Harbormaster completed remote builds in B19021: Diff 45239.Jan 4 2018, 10:14 PM

epriestley requested review of this revision.Jan 4 2018, 10:14 PM

👍

This revision is now accepted and ready to land.Jan 4 2018, 10:15 PM

Closed by commit rP554359203467: Add a couple of clarifying comments to the Mercurial protocol parser (authored by epriestley). · Explain WhyJan 4 2018, 10:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

ssh/

DiffusionMercurialWireClientSSHProtocolChannel.php

19 lines

Diff 45240

View Options

src/applications/diffusion/ssh/DiffusionMercurialWireClientSSHProtocolChannel.php

Add a couple of clarifying comments to the Mercurial protocol parserClosedPublicActions