Page MenuHomePhabricator
Differential D18833

Fix an issue where blame could fatal for unrecognized authors
ClosedPublic
Actions

Authored by epriestley on Dec 18 2017, 2:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 6:05 PM
Unknown Object (File)
Tue, Jan 21, 5:15 PM
Unknown Object (File)
Fri, Jan 17, 7:44 PM
Unknown Object (File)
Jan 3 2025, 8:17 PM
Unknown Object (File)
Dec 30 2024, 9:45 PM
Unknown Object (File)
Dec 27 2024, 6:03 PM
Unknown Object (File)
Dec 20 2024, 8:59 PM
Unknown Object (File)
Dec 19 2024, 12:00 AM
View All Files
Subscribers
None
Tokens
"Like" token, awarded by janitorial.

Details

Reviewers
amckinley
Commits
rP563d42d40e15: (stable) Fix an issue where blame could fatal for unrecognized authors
rPe411d75964e5: Fix an issue where blame could fatal for unrecognized authors
Summary

See PHI255. See https://discourse.phabricator-community.org/t/error-generating-blame-data/766.

Test Plan
  • Viewed a file contributed to by users with no Phabricator user accounts, in Diffusion.
  • Enabled blame.
  • Before patch: blame failed, fatal in logs.
  • After patch: blame worked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
14 lines

Diff 45189

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility