Fix an issue where blame could fatal for unrecognized authors
ClosedPublic
Actions

Authored by epriestley on Dec 18 2017, 2:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Jun 17 2025, 2:25 AM

	Unknown Object (File)
	May 20 2025, 7:14 AM

	Unknown Object (File)
	May 20 2025, 1:53 AM

	Unknown Object (File)
	May 9 2025, 2:41 PM

	Unknown Object (File)
	May 8 2025, 7:43 PM

	Unknown Object (File)
	May 6 2025, 9:55 AM

	Unknown Object (File)
	May 5 2025, 7:17 PM

	Unknown Object (File)
	Apr 13 2025, 11:57 PM

View All Files

Subscribers

None

Tokens

"Like" token, awarded by janitorial.

Details

Reviewers

amckinley

Commits

rP563d42d40e15: (stable) Fix an issue where blame could fatal for unrecognized authors
rPe411d75964e5: Fix an issue where blame could fatal for unrecognized authors

Summary

See PHI255. See https://discourse.phabricator-community.org/t/error-generating-blame-data/766.

Test Plan

Viewed a file contributed to by users with no Phabricator user accounts, in Diffusion.
Enabled blame.
Before patch: blame failed, fatal in logs.
After patch: blame worked.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 18 2017, 2:31 PM

Harbormaster completed remote builds in B18953: Diff 45178.Dec 18 2017, 2:32 PM

epriestley requested review of this revision.Dec 18 2017, 2:32 PM

janitorial awarded a token.Dec 18 2017, 3:32 PM

amckinley accepted this revision.Dec 20 2017, 6:21 PM

This revision is now accepted and ready to land.Dec 20 2017, 6:21 PM

Closed by commit rPe411d75964e5: Fix an issue where blame could fatal for unrecognized authors (authored by epriestley). · Explain WhyDec 20 2017, 7:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

14 lines

Diff 45189

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Fix an issue where blame could fatal for unrecognized authorsClosedPublicActions