Page MenuHomePhabricator
Differential D18833

Fix an issue where blame could fatal for unrecognized authors
ClosedPublic
Actions

Authored by epriestley on Dec 18 2017, 2:31 PM.
Tags
None
Referenced Files
F18849986: D18833.id.diff
Thu, Oct 30, 1:38 PM
F18842963: D18833.diff
Tue, Oct 28, 7:58 PM
F18816171: D18833.diff
Tue, Oct 21, 5:16 AM
F18806619: D18833.diff
Sat, Oct 18, 8:37 PM
F18790879: D18833.id45189.diff
Wed, Oct 15, 8:20 PM
F18771232: D18833.id45189.diff
Wed, Oct 8, 6:30 PM
F18748815: D18833.id45178.diff
Sat, Oct 4, 12:55 AM
F18747006: D18833.diff
Fri, Oct 3, 2:14 PM
View All Files
Subscribers
None
Tokens
"Like" token, awarded by janitorial.

Details

Reviewers
amckinley
Commits
rP563d42d40e15: (stable) Fix an issue where blame could fatal for unrecognized authors
rPe411d75964e5: Fix an issue where blame could fatal for unrecognized authors
Summary

See PHI255. See https://discourse.phabricator-community.org/t/error-generating-blame-data/766.

Test Plan
  • Viewed a file contributed to by users with no Phabricator user accounts, in Diffusion.
  • Enabled blame.
  • Before patch: blame failed, fatal in logs.
  • After patch: blame worked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
14 lines

Diff 45189

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility