Page MenuHomePhabricator
Differential D18833

Fix an issue where blame could fatal for unrecognized authors
ClosedPublic
Actions

Authored by epriestley on Dec 18 2017, 2:31 PM.
Tags
None
Referenced Files
F18509212: D18833.id.diff
Fri, Sep 5, 3:17 AM
F18501886: D18833.diff
Thu, Sep 4, 10:02 PM
F18461005: D18833.diff
Mon, Sep 1, 7:46 PM
F18352842: D18833.diff
Wed, Aug 27, 12:05 AM
F18248387: D18833.id.diff
Thu, Aug 21, 1:12 PM
F18236216: D18833.diff
Wed, Aug 20, 8:08 PM
F18101938: D18833.diff
Aug 9 2025, 4:50 PM
F17926663: D18833.id45189.diff
Jul 30 2025, 1:30 PM
View All Files
Subscribers
None
Tokens
"Like" token, awarded by janitorial.

Details

Reviewers
amckinley
Commits
rP563d42d40e15: (stable) Fix an issue where blame could fatal for unrecognized authors
rPe411d75964e5: Fix an issue where blame could fatal for unrecognized authors
Summary

See PHI255. See https://discourse.phabricator-community.org/t/error-generating-blame-data/766.

Test Plan
  • Viewed a file contributed to by users with no Phabricator user accounts, in Diffusion.
  • Enabled blame.
  • Before patch: blame failed, fatal in logs.
  • After patch: blame worked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
14 lines

Diff 45189

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility