Default the prompt for "Amend HEAD with these patches" to true
ClosedPublic
Actions

Authored by alexmv on Dec 12 2017, 1:38 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC9a2541c08d56: (stable) Promote 2017 Week 49
rARC249f3a80fe77: Default the prompt for "Amend HEAD with these patches" to true

Summary

Most users, if they have gone through the trouble of
accepting the auto-fixes, are most likely going to want to take those
changes and attempt to land with them. Assuming "Y" for this prompt
streamlines for the more likely flow.

Test Plan

arc lint

Diff Detail

Repository

rARC Arcanist

Branch

default-amend-true (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18940
Build 25542: Run Core Tests
Build 25541: arc lint + arc unit

Event Timeline

alexmv created this revision.Dec 12 2017, 1:38 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 12 2017, 1:38 AM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B18940: Diff 45167.Dec 12 2017, 1:39 AM

alexmv requested review of this revision.Dec 12 2017, 1:39 AM

epriestley accepted this revision.Dec 12 2017, 1:59 AM

This revision is now accepted and ready to land.Dec 12 2017, 1:59 AM

Herald added a subscriber: Korvin. · View Herald TranscriptDec 12 2017, 1:59 AM

Closed by commit rARC249f3a80fe77: Default the prompt for "Amend HEAD with these patches" to true (authored by alexmv). · Explain WhyDec 12 2017, 9:43 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistLintWorkflow.php

3 lines

Diff 45167

View Options

src/workflow/ArcanistLintWorkflow.php

Default the prompt for "Amend HEAD with these patches" to trueClosedPublicActions