Page MenuHomePhabricator

Hide archived projects only on workboards, not hovercards
ClosedPublic

Authored by epriestley on Nov 27 2017, 10:13 PM.
Tags
None
Referenced Files
F15535794: D18783.id.diff
Thu, Apr 24, 6:43 AM
F15528960: D18783.id45076.diff
Tue, Apr 22, 3:26 PM
F15515223: D18783.diff
Fri, Apr 18, 8:44 AM
F15426579: D18783.diff
Mar 23 2025, 9:50 AM
F15418653: D18783.id45077.diff
Mar 21 2025, 12:37 AM
F15379289: D18783.diff
Mar 13 2025, 8:03 PM
Unknown Object (File)
Mar 3 2025, 5:16 PM
Unknown Object (File)
Feb 23 2025, 10:14 PM
Subscribers
None

Details

Summary

See PHI225. Previously, see D15335 / T10413. On workboards, we hide archived project tags since they aren't terribly useful in that context, at least most of the time. Originally, see T10349#159916 and D15297.

However, hovercards reuse this display logic, and it's inconsistent/confusing to hide them there, since the actual "Tags" elements on task pages show them. Narrow the scope of this rule.

Test Plan
  • Viewed a hovercard for a task with an archived project tagged, saw archived project.
  • Viewed a workboard for the same task, saw only unarchived projects other than the current board tagged (this behavior is unchanged).

Diff Detail

Repository
rP Phabricator
Branch
hidetags
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18857
Build 25420: Run Core Tests
Build 25419: arc lint + arc unit