Differential D18781

Include OpenGraph prefix material in <html> tag if OpenGraph is enabled
ClosedPublic
Actions

Authored by epriestley on Nov 22 2017, 7:27 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13018: Support Discourse's specific dialect of OpenGraph metadata tags to enrich Discourse "OneBox" previews

Commits

rPc3d6c4b0ee8e: Include OpenGraph prefix material in <html> tag if OpenGraph is enabled

Summary

Ref T13018. Discourse doesn't seem to be picking this up yet (see https://discourse.phabricator-community.org/t/opengraph-test-topic/762) so maybe it really needs this meta-meta-XML stuff?

Test Plan

Will push.

Diff Detail

Repository

rP Phabricator

Branch

og2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18847
Build 25406: Run Core Tests
Build 25405: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 22 2017, 7:27 PM

Harbormaster completed remote builds in B18847: Diff 45068.Nov 22 2017, 7:28 PM

epriestley requested review of this revision.Nov 22 2017, 7:28 PM

Also use a favicon-like image instead of the default logo image, since the logo image is white-on-transparent.

Harbormaster completed remote builds in B18848: Diff 45069.Nov 22 2017, 7:31 PM

amckinley accepted this revision.Nov 22 2017, 7:35 PM

This revision is now accepted and ready to land.Nov 22 2017, 7:35 PM

Closed by commit rPc3d6c4b0ee8e: Include OpenGraph prefix material in <html> tag if OpenGraph is enabled (authored by epriestley). · Explain WhyNov 22 2017, 7:37 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13018: Support Discourse's specific dialect of OpenGraph metadata tags to enrich Discourse "OneBox" previews.Nov 22 2017, 11:31 PM

Revision Contents
Changeset List

Path

Size

src/

view/

page/

AphrontPageView.php

9 lines

Diff 45068

View Options

src/view/page/AphrontPageView.php

Include OpenGraph prefix material in <html> tag if OpenGraph is enabledClosedPublicActions