Page MenuHomePhabricator

Freeze "maniphest.gettasktransactions" and make status/priority transactions more consistent
ClosedPublic

Authored by epriestley on Nov 22 2017, 2:15 PM.
Tags
None
Referenced Files
F15520453: D18777.id45064.diff
Sun, Apr 20, 6:46 AM
F15456848: D18777.diff
Sun, Mar 30, 12:36 PM
F15439064: D18777.id.diff
Wed, Mar 26, 5:30 AM
F15426494: D18777.diff
Mar 23 2025, 9:07 AM
F15411286: D18777.diff
Mar 19 2025, 8:58 AM
F15411236: D18777.diff
Mar 19 2025, 8:56 AM
F15411169: D18777.diff
Mar 19 2025, 8:53 AM
F15411033: D18777.diff
Mar 19 2025, 8:47 AM
Subscribers
None

Details

Summary

Ref T13020. See PHI221.

Freeze legacy method maniphest.gettasktransactions in favor of modern method transaction.search.

Remove legacy "null on create" behavior from Maniphest status and priority transactions. This behavior is obsolete with EditEngine, and leads to inconsistent transaction sets in the transaction record.

The desired behavior is that transactions which don't do anything (e.g., default value was not changed) don't appear in the transaction log.

Test Plan
  • Viewed API UI and saw maniphest.gettasktransactions marked as "Frozen".
  • Created a new task via web UI (without changing status/priority), queried transactions with maniphest.gettasktransacitons/transaction.search, no longer saw "null on create" no-op transactions in record.
    • Web UI is unchanged, since these transactions were hidden before and now do not exist.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable