Page MenuHomePhabricator

Warn and prevent 1-up/2-up switch in Differential if the user is editing an inline
ClosedPublic

Authored by epriestley on Nov 15 2017, 5:28 PM.
Tags
None
Referenced Files
F17830359: D18774.id45050.diff
Sat, Jul 26, 11:01 AM
F17817377: D18774.id.diff
Fri, Jul 25, 11:30 PM
F17801413: D18774.diff
Fri, Jul 25, 7:46 AM
F17702971: D18774.diff
Wed, Jul 16, 12:11 AM
Unknown Object (File)
Apr 28 2025, 11:53 AM
Unknown Object (File)
Apr 26 2025, 10:38 PM
Unknown Object (File)
Apr 25 2025, 10:55 AM
Unknown Object (File)
Apr 24 2025, 10:48 PM
Subscribers
None

Details

Summary

See PHI180. Currently, if you begin creating or editing an inline and then swap display modes (for example, with "View Unified"), your edit is lost.

Persisting the editor state is complicated and this is very rare, so just prevent the action and warn the user instead.

Also make the warning persist for a little longer since a few of the messages, including this one, take a couple seconds to read now.

Test Plan
  • Edited a comment, tried to swap display modes, got a warning.
  • Swapped display modes normally with no comment being edited.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable