Page MenuHomePhabricator

Warn and prevent 1-up/2-up switch in Differential if the user is editing an inline
ClosedPublic

Authored by epriestley on Nov 15 2017, 5:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 5 2024, 4:55 PM
Unknown Object (File)
Feb 11 2024, 4:24 PM
Unknown Object (File)
Jan 23 2024, 3:54 PM
Unknown Object (File)
Dec 25 2023, 12:38 PM
Unknown Object (File)
Dec 18 2023, 6:39 AM
Unknown Object (File)
Nov 30 2023, 6:24 AM
Unknown Object (File)
Nov 19 2023, 10:18 AM
Unknown Object (File)
Oct 26 2023, 3:30 AM
Subscribers
None

Details

Summary

See PHI180. Currently, if you begin creating or editing an inline and then swap display modes (for example, with "View Unified"), your edit is lost.

Persisting the editor state is complicated and this is very rare, so just prevent the action and warn the user instead.

Also make the warning persist for a little longer since a few of the messages, including this one, take a couple seconds to read now.

Test Plan
  • Edited a comment, tried to swap display modes, got a warning.
  • Swapped display modes normally with no comment being edited.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable