Page MenuHomePhabricator

Warn and prevent 1-up/2-up switch in Differential if the user is editing an inline
ClosedPublic

Authored by epriestley on Nov 15 2017, 5:28 PM.
Tags
None
Referenced Files
F15555524: D18774.id45049.diff
Mon, Apr 28, 11:53 AM
F15548235: D18774.id45050.diff
Sat, Apr 26, 10:38 PM
F15541128: D18774.id.diff
Fri, Apr 25, 10:55 AM
F15539013: D18774.diff
Thu, Apr 24, 10:48 PM
F15536275: D18774.diff
Thu, Apr 24, 8:48 AM
F15488006: D18774.id45049.diff
Thu, Apr 10, 6:39 PM
F15470984: D18774.id45050.diff
Apr 5 2025, 2:39 AM
F15467720: D18774.id45049.diff
Apr 3 2025, 5:33 PM
Subscribers
None

Details

Summary

See PHI180. Currently, if you begin creating or editing an inline and then swap display modes (for example, with "View Unified"), your edit is lost.

Persisting the editor state is complicated and this is very rare, so just prevent the action and warn the user instead.

Also make the warning persist for a little longer since a few of the messages, including this one, take a couple seconds to read now.

Test Plan
  • Edited a comment, tried to swap display modes, got a warning.
  • Swapped display modes normally with no comment being edited.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable