Differential D18758

Don't include resigned reviewers in the Differential "To" list
ClosedPublic
Actions

Authored by epriestley on Nov 1 2017, 6:12 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T12689: Mail is still received after resigning from a revision

Commits

rP03d059dd26e2: Don't include resigned reviewers in the Differential "To" list

Summary

Ref T12689. See PHI178. This isn't a complete solution (you may still get mailed via packages/projects) but should fix the obvious issue, where "Resigned" reviewers are incorrectly always sent mail directly.

Test Plan

Had Alice resign, interacted as Bailey, no mail to Alice.

Diff Detail

Repository

rP Phabricator

Branch

adiff3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18797
Build 25335: Run Core Tests
Build 25334: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 1 2017, 6:12 PM

Harbormaster completed remote builds in B18797: Diff 45019.Nov 1 2017, 6:13 PM

epriestley requested review of this revision.Nov 1 2017, 6:13 PM

amckinley accepted this revision.Nov 1 2017, 8:49 PM

This revision is now accepted and ready to land.Nov 1 2017, 8:49 PM

Closed by commit rP03d059dd26e2: Don't include resigned reviewers in the Differential "To" list (authored by epriestley). · Explain WhyNov 2 2017, 12:22 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

4 lines

Diff 45019

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Don't include resigned reviewers in the Differential "To" listClosedPublicActions