Page MenuHomePhabricator
Differential D18758

Don't include resigned reviewers in the Differential "To" list
ClosedPublic
Actions

Authored by epriestley on Nov 1 2017, 6:12 PM.
Tags
None
Referenced Files
F15565408: D18758.id45019.diff
Thu, May 1, 2:32 AM
F15559103: D18758.id45024.diff
Tue, Apr 29, 7:04 AM
F15550537: D18758.id.diff
Sun, Apr 27, 12:12 PM
F15545028: D18758.diff
Sat, Apr 26, 8:37 AM
F15513201: D18758.diff
Thu, Apr 17, 5:14 PM
F15466218: D18758.id.diff
Apr 3 2025, 3:03 AM
F15455830: D18758.diff
Mar 30 2025, 5:07 AM
F15452711: D18758.id45019.diff
Mar 29 2025, 6:52 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T12689: Mail is still received after resigning from a revision
Commits
rP03d059dd26e2: Don't include resigned reviewers in the Differential "To" list
Summary

Ref T12689. See PHI178. This isn't a complete solution (you may still get mailed via packages/projects) but should fix the obvious issue, where "Resigned" reviewers are incorrectly always sent mail directly.

Test Plan

Had Alice resign, interacted as Bailey, no mail to Alice.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
4 lines

Diff 45024

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
Phabricator · Built by Phacility