Don't include resigned reviewers in the Differential "To" list
ClosedPublic
Actions

Authored by epriestley on Nov 1 2017, 6:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 25, 6:19 AM

	Unknown Object (File)
	Feb 9 2025, 3:25 AM

	Unknown Object (File)
	Feb 3 2025, 2:34 AM

	Unknown Object (File)
	Jan 28 2025, 2:53 AM

	Unknown Object (File)
	Jan 25 2025, 4:57 AM

	Unknown Object (File)
	Jan 23 2025, 10:15 PM

	Unknown Object (File)
	Jan 21 2025, 3:36 PM

	Unknown Object (File)
	Jan 21 2025, 3:07 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T12689: Mail is still received after resigning from a revision

Commits

rP03d059dd26e2: Don't include resigned reviewers in the Differential "To" list

Summary

Ref T12689. See PHI178. This isn't a complete solution (you may still get mailed via packages/projects) but should fix the obvious issue, where "Resigned" reviewers are incorrectly always sent mail directly.

Test Plan

Had Alice resign, interacted as Bailey, no mail to Alice.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 1 2017, 6:12 PM

Harbormaster completed remote builds in B18797: Diff 45019.Nov 1 2017, 6:13 PM

epriestley requested review of this revision.Nov 1 2017, 6:13 PM

amckinley accepted this revision.Nov 1 2017, 8:49 PM

This revision is now accepted and ready to land.Nov 1 2017, 8:49 PM

Closed by commit rP03d059dd26e2: Don't include resigned reviewers in the Differential "To" list (authored by epriestley). · Explain WhyNov 2 2017, 12:22 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

4 lines

Diff 45024

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Don't include resigned reviewers in the Differential "To" listClosedPublicActions