After "Request Review", move revisions with voided "Accepts" into "Ready to Review", not "Waiting on Other Reviewers"
ClosedPublic
Actions

Authored by epriestley on Nov 1 2017, 6:00 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T12539: Revision with an older "accept" showed up in "waiting on other reviewers" after "request review"

Commits

rP6ecdadb76a95: After "Request Review", move revisions with voided "Accepts" into "Ready to…

Summary

Depends on D18756. Fixes T12539. See PHI190. Currently, when this occurs:

Alice accepts.
Bailey requests review.
Alice views her dashboard.

...the revision appears in "Waiting on Other Reviewers" (regardless of whether other reviewers actually exist or not).

Instead, ignore these voided/non-current accepts and let the revisions appear in "Ready to Review", which is more natural.

Test Plan

Went through the steps above. On master, saw revision in "Waiting on Other Reviewers". After patch, saw it in "Ready to Review".

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 1 2017, 6:00 PM

Harbormaster completed remote builds in B18796: Diff 45018.Nov 1 2017, 6:01 PM

epriestley requested review of this revision.Nov 1 2017, 6:01 PM

amckinley accepted this revision.Nov 1 2017, 8:50 PM

This revision is now accepted and ready to land.Nov 1 2017, 8:50 PM

Closed by commit rP6ecdadb76a95: After "Request Review", move revisions with voided "Accepts" into "Ready to… (authored by epriestley). · Explain WhyNov 2 2017, 12:20 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionRequiredActionResultBucket.php

10 lines

DifferentialRevisionResultBucket.php

13 lines

Diff 45023

View Options

src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php