Page MenuHomePhabricator
Differential D18757

After "Request Review", move revisions with voided "Accepts" into "Ready to Review", not "Waiting on Other Reviewers"
ClosedPublic
Actions

Authored by epriestley on Nov 1 2017, 6:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 5:55 PM
Unknown Object (File)
Tue, Apr 16, 5:55 PM
Unknown Object (File)
Tue, Apr 16, 4:47 PM
Unknown Object (File)
Sat, Apr 13, 3:16 AM
Unknown Object (File)
Tue, Apr 9, 11:23 PM
Unknown Object (File)
Tue, Apr 9, 9:11 AM
Unknown Object (File)
Sun, Apr 7, 8:12 PM
Unknown Object (File)
Sat, Apr 6, 1:34 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T12539: Revision with an older "accept" showed up in "waiting on other reviewers" after "request review"
Commits
rP6ecdadb76a95: After "Request Review", move revisions with voided "Accepts" into "Ready to…
Summary

Depends on D18756. Fixes T12539. See PHI190. Currently, when this occurs:

  • Alice accepts.
  • Bailey requests review.
  • Alice views her dashboard.

...the revision appears in "Waiting on Other Reviewers" (regardless of whether other reviewers actually exist or not).

Instead, ignore these voided/non-current accepts and let the revisions appear in "Ready to Review", which is more natural.

Test Plan

Went through the steps above. On master, saw revision in "Waiting on Other Reviewers". After patch, saw it in "Ready to Review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
query/
10 lines
13 lines

Diff 45023

View Options

src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionResultBucket.php

Loading...
Phabricator · Built by Phacility