Page MenuHomePhabricator

Make `bin/storage dump` insert CREATE DATABASE and USE statements
ClosedPublic

Authored by epriestley on Oct 13 2017, 8:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 6, 2:15 AM
Unknown Object (File)
Fri, Mar 29, 11:14 AM
Unknown Object (File)
Mar 10 2024, 5:54 AM
Unknown Object (File)
Feb 26 2024, 1:35 PM
Unknown Object (File)
Feb 3 2024, 5:04 PM
Unknown Object (File)
Jan 17 2024, 1:53 AM
Unknown Object (File)
Dec 27 2023, 12:17 PM
Unknown Object (File)
Dec 27 2023, 12:17 PM
Subscribers
None

Details

Summary

Ref T13000. The new approach for dumping database-by-database means that we don't get CREATE DATABASE or USE statements, which makes importing the dump again inconvenient.

Manually stitch these into the dump.

Test Plan
  • Used bin/storage dump --namespace ... to dump a smaller local instance.
  • Used bin/storage destroy --namespace ..., to destroy the namespace, then inported the dump cleanly.
  • Verified that each CREATE DATABASE statement appears only once.
  • Verified that bin/storage renamespace --live can correctly process this file.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable