Page MenuHomePhabricator
Differential D18700

Add a rough "multipart/form-data" stream parser
ClosedPublic
Actions

Authored by epriestley on Oct 10 2017, 8:36 PM.
Tags
None
Referenced Files
F14829946: D18700.diff
Wed, Jan 29, 6:50 PM
Unknown Object (File)
Tue, Jan 28, 12:53 PM
Unknown Object (File)
Tue, Jan 28, 2:51 AM
Unknown Object (File)
Fri, Jan 24, 10:43 PM
Unknown Object (File)
Fri, Jan 24, 10:40 PM
Unknown Object (File)
Fri, Jan 24, 10:40 PM
Unknown Object (File)
Fri, Jan 24, 10:40 PM
Unknown Object (File)
Tue, Jan 21, 9:33 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13008: Process slot exhaustion in Phacility web tier
Commits
rPHUf46b445bdc5b: Add a rough "multipart/form-data" stream parser
Summary

Depends on D18699. Ref T13008. This only handles the basics (and doesn't stream files to disk yet) but provides a stream-oriented parser for multipart/form-data HTTP requests.

I'm going to integrate this into web workflows next and add coverage / fix bugs as I hit them.

Test Plan

Added basic unit tests, which pass.

Diff Detail

Repository
rPHU libphutil
Branch
post2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18668
Build 25147: Run Core Tests
Build 25146: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
6 lines
aphront/
multipartparser/
249 lines
66 lines
__tests__/
45 lines
data/
5 lines

Diff 44892

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/aphront/multipartparser/AphrontMultipartParser.php

Loading...
View Options

src/aphront/multipartparser/AphrontMultipartPart.php

Loading...
View Options

src/aphront/multipartparser/__tests__/AphrontMultipartParserTestCase.php

Loading...
View Options

src/aphront/multipartparser/__tests__/data/simple.txt

Loading...
Phabricator · Built by Phacility