Page MenuHomePhabricator

For backup persitsence, mark the "common ngrams" table as a data table, not an index table
ClosedPublic

Authored by epriestley on Oct 10 2017, 12:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 12:56 AM
Unknown Object (File)
Thu, Nov 14, 8:36 PM
Unknown Object (File)
Mon, Nov 11, 11:03 AM
Unknown Object (File)
Sat, Nov 9, 2:46 PM
Unknown Object (File)
Thu, Nov 7, 2:19 PM
Unknown Object (File)
Oct 15 2024, 7:36 PM
Unknown Object (File)
Oct 7 2024, 3:37 PM
Unknown Object (File)
Oct 1 2024, 6:09 PM
Subscribers
None

Details

Summary

Ref T13000. Garbage collecting common ngrams is slow because MySQL isn't all that great at deleting rows quickly. See PHI96, where it looks like it's going to take a week to GC ngrams for a ~million objects at a relatively conservative 0.15 threshold.

In the event of a restore, we can reduce the impact by persisting this table so the ngrams just don't get built when the reindex happens.

Test Plan

Viewed schema in Config, saw common ngrams tables marked as "Data" instead of "Index".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable