Page MenuHomePhabricator

For backup persitsence, mark the "common ngrams" table as a data table, not an index table
ClosedPublic

Authored by epriestley on Oct 10 2017, 12:04 AM.

Details

Summary

Ref T13000. Garbage collecting common ngrams is slow because MySQL isn't all that great at deleting rows quickly. See PHI96, where it looks like it's going to take a week to GC ngrams for a ~million objects at a relatively conservative 0.15 threshold.

In the event of a restore, we can reduce the impact by persisting this table so the ngrams just don't get built when the reindex happens.

Test Plan

Viewed schema in Config, saw common ngrams tables marked as "Data" instead of "Index".

Diff Detail

Repository
rP Phabricator
Branch
cache1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18664
Build 25141: Run Core Tests
Build 25140: arc lint + arc unit