Page MenuHomePhabricator
Differential D18693

Fix spelling
ClosedPublic
Actions

Authored by 0 on Oct 9 2017, 2:57 AM.
Tags
None
Referenced Files
F14090248: D18693.diff
Sun, Nov 24, 4:39 PM
Unknown Object (File)
Sat, Nov 23, 2:55 PM
Unknown Object (File)
Wed, Nov 20, 5:17 PM
Unknown Object (File)
Sat, Nov 16, 6:20 PM
Unknown Object (File)
Thu, Nov 14, 7:06 AM
Unknown Object (File)
Fri, Nov 8, 11:17 AM
Unknown Object (File)
Thu, Nov 7, 6:56 PM
Unknown Object (File)
Fri, Nov 1, 2:53 PM
View All Files
Subscribers
epriestley
yelirekim
Restricted Owners Package

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rP9bd6a3705559: Fix spelling
Summary

Noticed a couple of typos in the docs, and then things got out of hand.

Test Plan
  • Stared at the words until my eyes watered and the letters began to swim on the screen.
  • Consulted a dictionary.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0 created this revision.Oct 9 2017, 2:57 AM
Owners added a subscriber: Restricted Owners Package.Oct 9 2017, 2:57 AM
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 9 2017, 2:57 AM
Herald added subscribers: yelirekim, epriestley. · View Herald Transcript
0 added a comment.Oct 9 2017, 3:23 AM

Sorry about skipping the unit tests. I don't have the environment set up locally and I figured Harbormaster would take care of that.

I also found some typos that I didn't fix here because they're in strings that look like keys and might require other changes:

epriestley accepted this revision.Oct 9 2017, 5:47 PM

Impressive, thanks!

This revision is now accepted and ready to land.Oct 9 2017, 5:47 PM
Closed by commit rP9bd6a3705559: Fix spelling (authored by 0, committed by epriestley). · Explain WhyOct 9 2017, 5:48 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in rPb58309318697: Fix Celerity map definition after spelling corrections.Oct 9 2017, 5:52 PM
epriestley added a comment.Oct 9 2017, 5:55 PM

PhabricatorFundApplication has tempate

This one can be fixed safely if you want to send a diff for it. "template" just controls which types of special policies a policy control is permitted to have (for example, the "Invitees" policy is only valid if a object is a Calendar Event). Misspelling it means "no special rules", so fixing the spelling will just make special rules available. Since there are currently no special policy rules for Fund Initiatives, fixing it will have no effect, at least in first-party code.

PhabricatorLDAPAuthProvider has anoynmous
HarbormasterBuildPlanDefaultViewCapability has harbomaster
LegalpadDocumentPreambleTransaction has premable

These are trickier to fix. The Legalpad one can be fixed with a one-line migration but the other two require a bit more work. Maybe file a task (I added you to Community) and/or add a // TODO: This is misspelled! so we hopefully catch it if anyone tries to copy/paste.

0 mentioned this in D18694: Change 'tempate' to 'template'.Oct 9 2017, 6:40 PM
0 mentioned this in T13005: Fix misspelled strings.Oct 9 2017, 6:48 PM
epriestley mentioned this in rPcf3e198b9f69: Change 'tempate' to 'template'.Oct 9 2017, 6:56 PM
0 added a comment.Oct 9 2017, 6:57 PM

Ack, I knew skipping the tests would somehow come back to bite me. Although it seems I can't run bin/celerity map without a database connection anyway.

PhabricatorFundApplication has tempate

This one can be fixed safely if you want to send a diff for it. "template" just controls which types of special policies a policy control is permitted to have (for example, the "Invitees" policy is only valid if a object is a Calendar Event). Misspelling it means "no special rules", so fixing the spelling will just make special rules available. Since there are currently no special policy rules for Fund Initiatives, fixing it will have no effect, at least in first-party code.

D18694

PhabricatorLDAPAuthProvider has anoynmous
HarbormasterBuildPlanDefaultViewCapability has harbomaster
LegalpadDocumentPreambleTransaction has premable

These are trickier to fix. The Legalpad one can be fixed with a one-line migration but the other two require a bit more work. Maybe file a task (I added you to Community) and/or add a // TODO: This is misspelled! so we hopefully catch it if anyone tries to copy/paste.

T13005, D18695

Large Diff

This large diff affects 157 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
scripts/
setup/
2 lines
src/
aphront/
httpparametertype/
2 lines
applications/
almanac/
editor/
2 lines
audit/
view/
2 lines
auth/
controller/
2 lines
2 lines
editor/
2 lines
factor/
__tests__/
2 lines
management/
2 lines
provider/
2 lines
base/
2 lines
controller/
2 lines
calendar/
editor/
2 lines
icon/
2 lines
util/
2 lines
xaction/
4 lines
4 lines
2 lines
config/
check/
2 lines
conpherence/
query/
2 lines
dashboard/
customfield/
2 lines
differential/
controller/
2 lines
customfield/
2 lines
editor/
2 lines
parser/
6 lines
storage/
2 lines
4 lines
typeahead/
2 lines
diffusion/
controller/
2 lines
editor/
6 lines
engine/
2 lines
gitlfs/
2 lines
herald/
2 lines
protocol/
2 lines
2 lines
4 lines
query/
2 lines
2 lines
xaction/
2 lines
2 lines
drydock/
blueprint/
4 lines
storage/
2 lines
worker/
6 lines
2 lines
files/
controller/
2 lines
management/
2 lines
fund/
editor/
2 lines
harbormaster/
conduit/
4 lines
storage/
configuration/
2 lines
legalpad/
controller/
2 lines
maniphest/
controller/
4 lines
editor/
2 lines
metamta/
management/
2 lines
receiver/
2 lines
owners/
storage/
__tests__/
2 lines
passphrase/
credentialtype/
2 lines
2 lines
view/
2 lines
people/
markup/
2 lines
query/
4 lines
2 lines
storage/
6 lines
phid/
handle/
pool/
2 lines
resolver/
2 lines
phortune/
provider/
2 lines
phrequent/
storage/
2 lines
phriction/
editor/
2 lines
policy/
filter/
2 lines
project/
query/
2 lines
remarkup/
2 lines
releeph/
differential/
2 lines
field/
selector/
2 lines
repository/
daemon/
2 lines
data/
4 lines
engine/
2 lines
management/
2 lines
storage/
4 lines
2 lines
2 lines
worker/
commitchangeparser/
2 lines
search/
engine/
2 lines
management/
2 lines
menuitem/
4 lines
settings/
panel/
2 lines
query/
2 lines
setting/
2 lines
subscriptions/
controller/
2 lines
transactions/
editengine/
4 lines
editor/
2 lines
typeahead/
datasource/
2 lines
uiexample/
examples/
2 lines
docs/
contributor/
6 lines
2 lines
2 lines
4 lines
user/
cluster/
2 lines
2 lines
2 lines
6 lines
2 lines
4 lines
configuration/
4 lines
2 lines
4 lines
2 lines
field/
2 lines
2 lines
4 lines
8 lines
2 lines
userguide/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
10 lines
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
infrastructure/
customfield/
field/
2 lines
daemon/
workers/
query/
4 lines
diff/
view/
2 lines
2 lines
env/
2 lines
internationalization/
translation/
6 lines
query/
policy/
4 lines
storage/
lisk/
2 lines
__tests__/
2 lines
management/
workflow/
4 lines
util/
2 lines
password/
8 lines
view/
2 lines
page/
2 lines
phui/
2 lines
webroot/
rsrc/
css/
phui/
4 lines
2 lines
js/
application/
conpherence/
2 lines
2 lines
diffusion/
2 lines
pholio/
2 lines
core/
4 lines
2 lines
phuix/
2 lines
2 lines

Diff 44881

View Options

scripts/setup/manage_garbage.php

View Options

src/aphront/httpparametertype/AphrontHTTPParameterType.php

View Options

src/applications/almanac/editor/AlmanacDeviceEditor.php

View Options

src/applications/audit/view/PhabricatorAuditListView.php

View Options

src/applications/auth/controller/PhabricatorAuthController.php

View Options

src/applications/auth/controller/PhabricatorAuthRegisterController.php

View Options

src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php

View Options

src/applications/auth/factor/__tests__/PhabricatorAuthInviteTestCase.php

View Options

src/applications/auth/management/PhabricatorAuthManagementRevokeWorkflow.php

View Options

src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php

View Options

src/applications/base/PhabricatorApplication.php

View Options

src/applications/base/controller/PhabricatorController.php

View Options

src/applications/calendar/editor/PhabricatorCalendarImportEditEngine.php

View Options

src/applications/calendar/icon/PhabricatorCalendarIconSet.php

View Options

src/applications/calendar/util/CalendarTimeUtil.php

View Options

src/applications/calendar/xaction/PhabricatorCalendarEventFrequencyTransaction.php

View Options

src/applications/calendar/xaction/PhabricatorCalendarEventInviteTransaction.php

View Options

src/applications/calendar/xaction/PhabricatorCalendarImportFrequencyTransaction.php

View Options

src/applications/config/check/PhabricatorStorageSetupCheck.php

View Options

src/applications/conpherence/query/ConpherenceThreadQuery.php

View Options

src/applications/dashboard/customfield/PhabricatorDashboardPanelTabsCustomField.php

View Options

src/applications/differential/controller/DifferentialController.php

View Options

src/applications/differential/customfield/DifferentialHarbormasterField.php

View Options

src/applications/differential/editor/DifferentialDiffEditor.php

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

View Options

src/applications/differential/storage/DifferentialModernHunk.php

View Options

src/applications/differential/storage/DifferentialRevision.php

View Options

src/applications/differential/typeahead/DifferentialResponsibleViewerFunctionDatasource.php

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

View Options

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

View Options

src/applications/diffusion/gitlfs/DiffusionGitLFSAuthenticateWorkflow.php

View Options

src/applications/diffusion/herald/HeraldCommitAdapter.php

View Options

src/applications/diffusion/protocol/DiffusionCommandEngine.php

View Options

src/applications/diffusion/protocol/DiffusionMercurialWireProtocol.php

View Options

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

View Options

src/applications/diffusion/query/DiffusionCachedResolveRefsQuery.php

View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

View Options

src/applications/diffusion/xaction/DiffusionCommitConcernTransaction.php

View Options

src/applications/diffusion/xaction/DiffusionCommitVerifyTransaction.php

View Options

src/applications/drydock/blueprint/DrydockBlueprintImplementation.php

View Options

src/applications/drydock/storage/DrydockAuthorization.php

View Options

src/applications/drydock/worker/DrydockLeaseUpdateWorker.php

View Options

src/applications/drydock/worker/DrydockWorker.php

View Options

src/applications/files/controller/PhabricatorFileDataController.php

View Options

src/applications/files/management/PhabricatorFilesManagementCatWorkflow.php

View Options

src/applications/fund/editor/FundInitiativeEditEngine.php

View Options

src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php

View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php

View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

View Options

src/applications/maniphest/controller/ManiphestReportController.php

View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

View Options

src/applications/metamta/management/PhabricatorMailManagementUnverifyWorkflow.php

View Options

src/applications/metamta/receiver/PhabricatorMailReceiver.php

View Options

src/applications/owners/storage/__tests__/PhabricatorOwnersPackageTestCase.php

View Options

src/applications/passphrase/credentialtype/PassphraseCredentialType.php

View Options

src/applications/passphrase/credentialtype/PassphraseSSHPrivateKeyTextCredentialType.php

View Options

src/applications/passphrase/view/PassphraseCredentialControl.php

View Options

src/applications/people/markup/PhabricatorMentionRemarkupRule.php

View Options

src/applications/people/query/PhabricatorPeopleQuery.php

View Options

src/applications/people/query/PhabricatorPeopleSearchEngine.php

View Options

src/applications/people/storage/PhabricatorUser.php

View Options

src/applications/phid/handle/pool/PhabricatorHandleList.php

View Options

src/applications/phid/resolver/PhabricatorPHIDResolver.php

View Options

src/applications/phortune/provider/PhortuneStripePaymentProvider.php

View Options

src/applications/phrequent/storage/PhrequentTimeBlock.php

View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php

View Options

src/applications/policy/filter/PhabricatorPolicyFilter.php

View Options

src/applications/project/query/PhabricatorProjectColumnQuery.php

View Options

src/applications/project/remarkup/ProjectRemarkupRule.php

View Options

src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php

View Options

src/applications/releeph/field/selector/ReleephDefaultFieldSelector.php

View Options

src/applications/repository/daemon/PhabricatorMercurialGraphStream.php

View Options

src/applications/repository/data/PhabricatorRepositoryURINormalizer.php

View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

View Options

src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

View Options

src/applications/repository/storage/PhabricatorRepositoryURI.php

View Options

src/applications/repository/storage/PhabricatorRepositoryWorkingCopyVersion.php

View Options

src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryMercurialCommitChangeParserWorker.php

View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

View Options

src/applications/search/management/PhabricatorSearchManagementWorkflow.php

View Options

src/applications/search/menuitem/PhabricatorMotivatorProfileMenuItem.php

View Options

src/applications/settings/panel/PhabricatorSettingsPanel.php

View Options

src/applications/settings/query/PhabricatorUserPreferencesQuery.php

View Options

src/applications/settings/setting/PhabricatorTimezoneSetting.php

View Options

src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php

View Options

src/applications/uiexample/examples/PhabricatorStatusUIExample.php

View Options

src/docs/contributor/cla.diviner

View Options

src/docs/contributor/describing_problems.diviner

View Options

src/docs/contributor/internationalization.diviner

View Options

src/docs/contributor/reproduction_steps.diviner

View Options

src/docs/user/cluster/cluster.diviner

View Options

src/docs/user/cluster/cluster_databases.diviner

View Options

src/docs/user/cluster/cluster_devices.diviner

View Options

src/docs/user/cluster/cluster_partitioning.diviner

View Options

src/docs/user/cluster/cluster_repositories.diviner

View Options

src/docs/user/cluster/cluster_search.diviner

View Options

src/docs/user/configuration/configuration_guide.diviner

View Options

src/docs/user/configuration/configuring_backups.diviner

View Options

src/docs/user/configuration/configuring_encryption.diviner

View Options

src/docs/user/configuration/managing_garbage.diviner

View Options

src/docs/user/field/conduit_changes.diviner

View Options

src/docs/user/field/darkconsole.diviner

View Options

src/docs/user/field/performance.diviner

View Options

src/docs/user/field/repository_imports.diviner

View Options

src/docs/user/field/xhprof.diviner

View Options

src/docs/user/userguide/almanac.diviner

View Options

src/docs/user/userguide/arcanist.diviner

View Options

src/docs/user/userguide/arcanist_lint.diviner

View Options

src/docs/user/userguide/calendar_exports.diviner

View Options

src/docs/user/userguide/calendar_imports.diviner

View Options

src/docs/user/userguide/conduit_edit.diviner

View Options

src/docs/user/userguide/diffusion_api.diviner

View Options

src/docs/user/userguide/diffusion_hosting.diviner

View Options

src/docs/user/userguide/diffusion_managing.diviner

View Options

src/docs/user/userguide/diffusion_uris.diviner

View Options

src/docs/user/userguide/drydock.diviner

View Options

src/docs/user/userguide/drydock_blueprints.diviner

View Options

src/docs/user/userguide/drydock_security.diviner

View Options

src/docs/user/userguide/forms.diviner

View Options

src/docs/user/userguide/herald.diviner

View Options

src/docs/user/userguide/jump.diviner

View Options

src/docs/user/userguide/owners.diviner

View Options

src/docs/user/userguide/projects.diviner

View Options

src/docs/user/userguide/remarkup.diviner

View Options

src/docs/user/userguide/search.diviner

View Options

src/docs/user/userguide/spaces.diviner

View Options

src/docs/user/userguide/users.diviner

View Options

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php

View Options

src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php

View Options

src/infrastructure/diff/view/PHUIDiffGraphView.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentTableScaffold.php

View Options

src/infrastructure/env/PhabricatorEnv.php

View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

View Options

src/infrastructure/storage/lisk/LiskDAO.php

View Options

src/infrastructure/storage/lisk/__tests__/LiskFixtureTestCase.php

View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

View Options

src/infrastructure/util/PhabricatorHash.php

View Options

src/infrastructure/util/password/PhabricatorPasswordHasher.php

View Options

src/view/AphrontView.php

View Options

src/view/page/PhabricatorStandardPageView.php

View Options

src/view/phui/PHUIHeaderView.php

View Options

webroot/rsrc/css/phui/phui-document.css

View Options

webroot/rsrc/css/phui/phui-header-view.css

View Options

webroot/rsrc/js/application/conpherence/behavior-menu.js

View Options

webroot/rsrc/js/application/conpherence/behavior-participant-pane.js

View Options

webroot/rsrc/js/application/diffusion/DiffusionLocateFileSource.js

View Options

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

View Options

webroot/rsrc/js/core/Prefab.js

View Options

webroot/rsrc/js/core/behavior-device.js

View Options

webroot/rsrc/js/phuix/PHUIXAutocomplete.js

View Options

webroot/rsrc/js/phuix/PHUIXDropdownMenu.js

Phabricator · Built by Phacility