Page MenuHomePhabricator

Fix spelling
ClosedPublic

Authored by 0 on Oct 9 2017, 2:57 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rP9bd6a3705559: Fix spelling
Summary

Noticed a couple of typos in the docs, and then things got out of hand.

Test Plan
  • Stared at the words until my eyes watered and the letters began to swim on the screen.
  • Consulted a dictionary.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Oct 9 2017, 2:57 AM

Sorry about skipping the unit tests. I don't have the environment set up locally and I figured Harbormaster would take care of that.

I also found some typos that I didn't fix here because they're in strings that look like keys and might require other changes:

This revision is now accepted and ready to land.Oct 9 2017, 5:47 PM
This revision was automatically updated to reflect the committed changes.

PhabricatorFundApplication has tempate

This one can be fixed safely if you want to send a diff for it. "template" just controls which types of special policies a policy control is permitted to have (for example, the "Invitees" policy is only valid if a object is a Calendar Event). Misspelling it means "no special rules", so fixing the spelling will just make special rules available. Since there are currently no special policy rules for Fund Initiatives, fixing it will have no effect, at least in first-party code.

PhabricatorLDAPAuthProvider has anoynmous
HarbormasterBuildPlanDefaultViewCapability has harbomaster
LegalpadDocumentPreambleTransaction has premable

These are trickier to fix. The Legalpad one can be fixed with a one-line migration but the other two require a bit more work. Maybe file a task (I added you to Community) and/or add a // TODO: This is misspelled! so we hopefully catch it if anyone tries to copy/paste.

Ack, I knew skipping the tests would somehow come back to bite me. Although it seems I can't run bin/celerity map without a database connection anyway.

PhabricatorFundApplication has tempate

This one can be fixed safely if you want to send a diff for it. "template" just controls which types of special policies a policy control is permitted to have (for example, the "Invitees" policy is only valid if a object is a Calendar Event). Misspelling it means "no special rules", so fixing the spelling will just make special rules available. Since there are currently no special policy rules for Fund Initiatives, fixing it will have no effect, at least in first-party code.

D18694

PhabricatorLDAPAuthProvider has anoynmous
HarbormasterBuildPlanDefaultViewCapability has harbomaster
LegalpadDocumentPreambleTransaction has premable

These are trickier to fix. The Legalpad one can be fixed with a one-line migration but the other two require a bit more work. Maybe file a task (I added you to Community) and/or add a // TODO: This is misspelled! so we hopefully catch it if anyone tries to copy/paste.

T13005, D18695