Fix a fatal on user email settings when `account.editable` is disabled
ClosedPublic
Actions

Authored by epriestley on Oct 4 2017, 2:18 PM.

Details

Reviewers

amckinley

Commits

rPb9fd5262509d: Fix a fatal on user email settings when `account.editable` is disabled

Summary

If account.editable is set to false, we try to add a null button and fatal:

Argument 1 passed to PHUIHeaderView::addActionLink() must be an instance of PHUIButtonView, null given, called in /srv/phabricator/phabricator/src/applications/settings/panel/PhabricatorSettingsPanel.php on line 290

Instead, don't try to render null as a button.

Test Plan

Configured account.editable false.
Viewed email address settings.
Before: fatal.
After: page works, no button is provided.

Diff Detail

Repository

rP Phabricator

Branch

editable1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18623
Build 25087: Run Core Tests
Build 25086: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 4 2017, 2:18 PM

Harbormaster completed remote builds in B18623: Diff 44841.Oct 4 2017, 2:19 PM

amckinley accepted this revision.Oct 4 2017, 3:26 PM

This revision is now accepted and ready to land.Oct 4 2017, 3:26 PM

Closed by commit rPb9fd5262509d: Fix a fatal on user email settings when `account.editable` is disabled (authored by epriestley). · Explain WhyOct 4 2017, 5:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

panel/

PhabricatorEmailAddressesSettingsPanel.php

6 lines

Diff 44841

View Options

src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php

Fix a fatal on user email settings when `account.editable` is disabledClosedPublicActions