Page MenuHomePhabricator

Fix a fatal on user email settings when `account.editable` is disabled
ClosedPublic

Authored by epriestley on Oct 4 2017, 2:18 PM.
Tags
None
Referenced Files
F13971897: D18677.id.diff
Thu, Oct 17, 3:57 PM
F13959029: D18677.diff
Mon, Oct 14, 5:31 PM
Unknown Object (File)
Aug 19 2024, 11:59 AM
Unknown Object (File)
Aug 7 2024, 12:15 AM
Unknown Object (File)
Aug 6 2024, 11:44 PM
Unknown Object (File)
Aug 2 2024, 3:33 PM
Unknown Object (File)
Aug 1 2024, 5:38 AM
Unknown Object (File)
Jul 29 2024, 3:52 AM
Subscribers
None

Details

Summary

If account.editable is set to false, we try to add a null button and fatal:

Argument 1 passed to PHUIHeaderView::addActionLink() must be an instance of PHUIButtonView, null given, called in /srv/phabricator/phabricator/src/applications/settings/panel/PhabricatorSettingsPanel.php on line 290

Instead, don't try to render null as a button.

Test Plan
  • Configured account.editable false.
  • Viewed email address settings.
  • Before: fatal.
  • After: page works, no button is provided.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable