Page MenuHomePhabricator

Fix a fatal on user email settings when `account.editable` is disabled
ClosedPublic

Authored by epriestley on Oct 4 2017, 2:18 PM.
Tags
None
Referenced Files
F18336154: D18677.id.diff
Mon, Aug 25, 9:29 AM
F18316698: D18677.diff
Sun, Aug 24, 10:17 AM
F18112653: D18677.id44843.diff
Aug 12 2025, 7:19 PM
F18112621: D18677.id44841.diff
Aug 12 2025, 7:11 PM
F18109741: D18677.id.diff
Aug 11 2025, 3:13 PM
F18106366: D18677.diff
Aug 10 2025, 10:20 PM
F18098479: D18677.id44841.diff
Aug 8 2025, 8:26 PM
F18097976: D18677.id44843.diff
Aug 8 2025, 5:18 PM
Subscribers
None

Details

Summary

If account.editable is set to false, we try to add a null button and fatal:

Argument 1 passed to PHUIHeaderView::addActionLink() must be an instance of PHUIButtonView, null given, called in /srv/phabricator/phabricator/src/applications/settings/panel/PhabricatorSettingsPanel.php on line 290

Instead, don't try to render null as a button.

Test Plan
  • Configured account.editable false.
  • Viewed email address settings.
  • Before: fatal.
  • After: page works, no button is provided.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable