Page MenuHomePhabricator

Fix a fatal on user email settings when `account.editable` is disabled
ClosedPublic

Authored by epriestley on Oct 4 2017, 2:18 PM.
Tags
None
Referenced Files
F19942340: D18677.diff
Wed, Apr 15, 5:57 PM
F19874833: D18677.id44843.diff
Mar 15 2026, 11:45 PM
F19802834: D18677.id44843.diff
Mar 1 2026, 7:12 PM
F19714460: D18677.id44841.diff
Feb 12 2026, 1:41 AM
F19562401: D18677.diff
Jan 31 2026, 1:29 PM
F19562399: D18677.diff
Jan 31 2026, 1:28 PM
F19274526: D18677.id44841.diff
Dec 23 2025, 12:17 AM
F19206408: D18677.diff
Dec 16 2025, 9:03 PM
Subscribers
None

Details

Summary

If account.editable is set to false, we try to add a null button and fatal:

Argument 1 passed to PHUIHeaderView::addActionLink() must be an instance of PHUIButtonView, null given, called in /srv/phabricator/phabricator/src/applications/settings/panel/PhabricatorSettingsPanel.php on line 290

Instead, don't try to render null as a button.

Test Plan
  • Configured account.editable false.
  • Viewed email address settings.
  • Before: fatal.
  • After: page works, no button is provided.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable