Paths

Table of Contentst

Correct bad context path when doing pattern search inside a repository
ClosedPublic
Actions

Authored by epriestley on Sep 29 2017, 9:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 7, 12:29 AM

	Unknown Object (File)
	Tue, Dec 17, 11:38 AM

	Unknown Object (File)
	Dec 6 2024, 3:32 AM

	Unknown Object (File)
	Nov 27 2024, 4:31 PM

	Unknown Object (File)
	Nov 26 2024, 2:04 PM

	Unknown Object (File)
	Nov 22 2024, 10:56 PM

	Unknown Object (File)
	Nov 19 2024, 11:12 AM

	Unknown Object (File)
	Nov 9 2024, 2:43 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPa39f5e11139a: Correct bad context path when doing pattern search inside a repository

Summary

Ref PHI101. It looks like this was maybe copy/pasted by mistake in recent design refactoring.

We need to pass the full path, not the basename() of the path, to the search form.

Test Plan

Searched inside scripts/test/, found results inside scripts/test/.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 29 2017, 9:50 PM

Harbormaster completed remote builds in B18589: Diff 44810.Sep 29 2017, 9:50 PM

amckinley accepted this revision.Sep 29 2017, 9:51 PM

This revision is now accepted and ready to land.Sep 29 2017, 9:51 PM

Harbormaster completed remote builds in B18589: Diff 44810.Sep 29 2017, 9:51 PM

Closed by commit rPa39f5e11139a: Correct bad context path when doing pattern search inside a repository (authored by epriestley). · Explain WhySep 29 2017, 9:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

3 lines

Diff 44811

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Correct bad context path when doing pattern search inside a repositoryClosedPublicActions