Paths

Table of Contentst

Correct bad context path when doing pattern search inside a repository
ClosedPublic
Actions

Authored by epriestley on Sep 29 2017, 9:50 PM.

Tags

None

Referenced Files

	F18893818: D18664.diff
	Fri, Nov 7, 1:19 PM

	F18890898: D18664.diff
	Fri, Nov 7, 10:02 AM

	F18817956: D18664.id44810.diff
	Tue, Oct 21, 7:49 PM

	F18751293: D18664.diff
	Oct 4 2025, 10:23 AM

	F18740515: D18664.id44811.diff
	Oct 2 2025, 3:53 AM

	F18696925: D18664.id.diff
	Sep 27 2025, 8:36 AM

	F18602408: D18664.id.diff
	Sep 13 2025, 3:01 PM

	F18595170: D18664.diff
	Sep 12 2025, 8:40 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPa39f5e11139a: Correct bad context path when doing pattern search inside a repository

Summary

Ref PHI101. It looks like this was maybe copy/pasted by mistake in recent design refactoring.

We need to pass the full path, not the basename() of the path, to the search form.

Test Plan

Searched inside scripts/test/, found results inside scripts/test/.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 29 2017, 9:50 PM

Harbormaster completed remote builds in B18589: Diff 44810.Sep 29 2017, 9:50 PM

amckinley accepted this revision.Sep 29 2017, 9:51 PM

This revision is now accepted and ready to land.Sep 29 2017, 9:51 PM

Harbormaster completed remote builds in B18589: Diff 44810.Sep 29 2017, 9:51 PM

Closed by commit rPa39f5e11139a: Correct bad context path when doing pattern search inside a repository (authored by epriestley). · Explain WhySep 29 2017, 9:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

3 lines

Diff 44811

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Correct bad context path when doing pattern search inside a repositoryClosedPublicActions