Page MenuHomePhabricator

Remove "arc lint --only-new"
ClosedPublic

Authored by epriestley on Sep 25 2017, 6:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 17, 2:09 PM
Unknown Object (File)
Sun, Sep 11, 2:27 PM
Unknown Object (File)
Fri, Sep 9, 7:11 PM
Unknown Object (File)
Aug 4 2022, 12:25 AM
Unknown Object (File)
Jul 28 2022, 3:46 AM
Unknown Object (File)
Jul 27 2022, 11:47 AM
Unknown Object (File)
Jul 14 2022, 8:31 PM
Unknown Object (File)
Jul 13 2022, 3:31 PM
Subscribers
None

Details

Summary

Ref T12996. Fixes T9749. This is a very old Facebook-specific thing which relies on other server-side Facebook-specific things and doesn't work properly anyway.

I don't actually remember what the use case for this flag was. It was either "the codebase has a million warnings, so showing warnings on files/lines you touched isn't good enough", or "weird warnings that raise lint on other lines", or some variation of those.

Regardless, I believe this feature benefits at most one install (Facebook circa 2011), and likely zero. It occasionally confuses normal users.

T9749 suggests a possible replacement workflow which is likely more practical, but I'd like to see a real problem description before considering this again.

Test Plan

Created this revision, grepped for only-new.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 25 2017, 6:31 PM
This revision was automatically updated to reflect the committed changes.