Page MenuHomePhabricator

Remove "arc lint --only-new"
ClosedPublic

Authored by epriestley on Sep 25 2017, 6:17 PM.
Tags
None
Referenced Files
F18859555: D18642.diff
Sun, Nov 2, 2:58 AM
F18855752: D18642.id44757.diff
Sat, Nov 1, 6:33 AM
F18851037: D18642.id44757.diff
Thu, Oct 30, 9:34 PM
F18770055: D18642.id44757.diff
Oct 8 2025, 10:32 AM
F18767915: D18642.diff
Oct 8 2025, 12:51 AM
F18761698: D18642.id.diff
Oct 6 2025, 3:46 PM
F18740377: D18642.id44757.diff
Oct 2 2025, 2:24 AM
F18740208: D18642.id.diff
Oct 2 2025, 1:07 AM
Subscribers
None

Details

Summary

Ref T12996. Fixes T9749. This is a very old Facebook-specific thing which relies on other server-side Facebook-specific things and doesn't work properly anyway.

I don't actually remember what the use case for this flag was. It was either "the codebase has a million warnings, so showing warnings on files/lines you touched isn't good enough", or "weird warnings that raise lint on other lines", or some variation of those.

Regardless, I believe this feature benefits at most one install (Facebook circa 2011), and likely zero. It occasionally confuses normal users.

T9749 suggests a possible replacement workflow which is likely more practical, but I'd like to see a real problem description before considering this again.

Test Plan

Created this revision, grepped for only-new.

Diff Detail

Repository
rARC Arcanist
Branch
ll3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18535
Build 24965: Run Core Tests
Build 24964: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 25 2017, 6:31 PM
This revision was automatically updated to reflect the committed changes.